CCE in LibraryUnit

[stevemessick]

Converting JS code to Dart is uncovering new bugs. Here's a stack trace. Source is below.

java.lang.ClassCastException: com.google.dart.compiler.ast.DartPropertyAccess cannot be cast to com.google.dart.compiler.ast.DartIdentifier
    at com.google.dart.compiler.ast.LibraryUnit$1.visitMethodDefinition(LibraryUnit.java:311)
    at com.google.dart.compiler.ast.LibraryUnit$1.visitMethodDefinition(LibraryUnit.java:1)
    at com.google.dart.compiler.ast.DartMethodDefinition.accept(DartMethodDefinition.java:90)
    at com.google.dart.compiler.ast.DartNodeTraverser.visit(DartNodeTraverser.java:413)
    at com.google.dart.compiler.ast.DartUnit.visitChildren(DartUnit.java:99)
    at com.google.dart.compiler.ast.DartNodeTraverser.visitNode(DartNodeTraverser.java:54)
    at com.google.dart.compiler.ast.DartNodeTraverser.visitUnit(DartNodeTraverser.java:391)
    at com.google.dart.compiler.ast.LibraryUnit.populateTopLevelNodes(LibraryUnit.java:324)
    at com.google.dart.compiler.DartCompiler$Compiler.parseOutOfDateFiles(DartCompiler.java:289)
    at com.google.dart.compiler.DartCompiler$Compiler.updateAndResolve(DartCompiler.java:204)
    at com.google.dart.compiler.DartCompiler$Compiler.access$4(DartCompiler.java:193)
    at com.google.dart.compiler.DartCompiler.analyzeLibrary(DartCompiler.java:1197)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.secureAnalyzeLibrary(DartCompilerUtilities.java:777)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities$ResolverRunnable.run(DartCompilerUtilities.java:440)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities$CompilerRunner.runSafe(DartCompilerUtilities.java:95)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.resolveUnit(DartCompilerUtilities.java:760)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.resolveUnit(DartCompilerUtilities.java:742)
    at com.google.dart.tools.core.utilities.compiler.DartCompilerUtilities.resolveUnit(DartCompilerUtilities.java:706)
    at com.google.dart.tools.ui.internal.text.editor.DartEditor.getAST(DartEditor.java:2010)
    at com.google.dart.tools.ui.internal.text.editor.DartTextHover.getHoverInfo(DartTextHover.java:46)
    at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:168)

import('dart:html');

// Content section used alot

main() {

  var content = document.query('content');

  if (!window.FileReader) {

    content.innerHTML = "<p>This browser doesnt support the File API</p>";

  } else {

  // Page Layout

  content.innerHTML =

    '<p>Pick a text file or drag one into this area <br> <input type="file" id="file" /></p>' +

    '<p><b>Name:</b> <span id="name"></span><br>' +

    '<b>File Size:</b> <span id="size"></span><br>' +

    '<b>Content:</b> <br><br> <pre id="file-content"></pre>' +

    '</p>';

  }

}

// Prints out file properties.

displayFile(file) {

  document.query('name').textContent = file.fileName;

  document.query('size').textContent = file.fileSize;

  document.

    document.getElementById('name').textContent = file.fileName;

    document.getElementById('size').textContent = file.fileSize;

    document.getElementById('file-content').style.border = "1px solid black";

    var reader = new FileReader();

    reader.onload = function(event) {

      document.getElementById('file-content').textContent =

        event.target.result;

    };

    reader.onerror = function() {

      document.getElementById('file-content').innerHTML = 'Unable to read ' + file.fileName;

    };

    reader.readAsText(file);

  }

  // Input handler

  document.getElementById('file').onchange = function() {

    displayFile(this.files[0]);

  };

  // Add invisible border to drop area

  content.style.border = '4px solid transparent';

  // Add dragging events

  content.ondragenter = function() {

    content.style.border = '4px solid #b1ecb3';

    return false;

  };

  content.ondragover = function() {

    return false;

  };

  content.ondragleave = function() {

    return false;

  };

  content.ondrop = function(event) {

    content.style.border = '4px solid transparent';

    displayFile(event.dataTransfer.files[0]);

    return false;

  };

}

[stevemessick]

Set owner to mmendez@google.com.

[DartBot]

This comment was originally written by mmendez@google.com

---

Issue #840 has been merged into this issue.

[DartBot]

This comment was originally written by mmendez@google.com

---

I think that this and issue #840 are related.

---

Set owner to @jtmcdole.

[jtmcdole]

Cannot repro with the code given:

dartc tmp.dart
tmp.dart/tmp.dart:87: Unexpected token 'STRING' (expected 'IDENTIFIER')
    86:
    87: document.getElementById('file').onchange = function() {
tmp.dart/tmp.dart:87: Unexpected token '.' (expected '{')
    86:
    87: document.getElementById('file').onchange = function() {
Compilation failed with 2 problems.

[jtmcdole]

Requires dumping code into the editor to try and repro. Looking at now.

[jtmcdole]

http://codereview.chromium.org/8913016/

[jtmcdole]

Added Fixed label.