-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing http client websocket #46037
Exposing http client websocket #46037
Conversation
Fixed by migrating to dict.items() which is available in both python2 and python3. TEST=Manual testing in python2 and python3. Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-win-release-x64-try Bug: #46029 Change-Id: I1c8363dfc44dc39f2430f84c4f22631a2e7203cd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200184 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Clement Skau <cskau@google.com>
…arge offset If the type arguments vector gets introduced in subclasses where the base classes have already many fields we may not be able to load the TAV in one instruction on ARM64. Issue flutter/flutter#82278 TEST=vm/dart{,_2}/flutter_regress_82278_test Change-Id: I164ef42af3afe8267fe23a8a11af9401776eccdb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199481 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Annotations are evaluated in the CFE and the VM does therefore not encounter any AST nodes anymore. TEST=Existing test suite. Change-Id: Id0ac60cf0d1a8d1667c79541c1de66765778ce90 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200183 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Clement Skau <cskau@google.com>
Change-Id: I0cfd2ad9e59c985f632d7038a64d903f6b472dd1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199480 Auto-Submit: Lasse R.H. Nielsen <lrn@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Change-Id: I8e00eb6094733238549ca259e4355032fc8c1cea Bug: #46020 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199681 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
In these tests I've tried to test a lot of the corner cases surrounding the addition of a `<type arguments>` selector to the grammar (which we intend to do as part of constructor tearoffs), to make sure that when we do so, we don't break any existing functionality. Change-Id: I765195cdd3745904f4aeb36663f59afe03381ab8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200001 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Fixes #46019. Change-Id: Ie4413fe013d7251e579f548e61674a8a4fc1d5df Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200185 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Change-Id: Ib7b1fad99b97e779fb8f929cc8e3d7b7837ccab0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200040 Reviewed-by: Phil Quitslund <pquitslund@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Solution for certificate pinning for web sockets.
Solves #34284