Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the portmanteau example #1800

Closed
kwalrath opened this issue Jul 29, 2019 · 4 comments
Closed

Fix the portmanteau example #1800

kwalrath opened this issue Jul 29, 2019 · 4 comments
Assignees
Labels
a.tut.tutorial Relates to the Tutorial section of dart.dev e1-hours Can complete in < 8 hours of normal, not dedicated, work fix.bug Needs fix of incorrect copy, code, or visual fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible. target.web Target apps on the web platform

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Jul 29, 2019

The DartPad example under https://dart.dev/tutorials/web/fetch-data#using-getString-function is broken because of a problem loading data.

The fix might be as simple as changing dartlang.org to dart.dev (which we should search for globally, anyway), or it might be more involved.

@kwalrath kwalrath added fix.bug Needs fix of incorrect copy, code, or visual p2-medium Necessary but not urgent concern. Resolve when possible. a.tut.tutorial Relates to the Tutorial section of dart.dev fix.examples Adds or changes example e1-hours Can complete in < 8 hours of normal, not dedicated, work labels Jul 29, 2019
@kwalrath kwalrath added the target.web Target apps on the web platform label Aug 26, 2019
@Arun8295
Copy link

Hi, I would like to take up this issue.

@Arun8295
Copy link

Arun8295 commented Sep 28, 2019

Modified the URL from dartlang.org to dart.dev and created new gist files

https://gist.github.com/Arun8295/acb2e9d00b3b13e0c672157a4546a9d2
https://gist.github.com/Arun8295/e0ed44f41317f0e40c8bc823506af3ed

Tested the changes in the below dartpad URL
https://dartpad.dev/experimental/embed-new-html.html?id=<< id >>

I need help to update this new gist URL instead of the existing one.

@kwalrath
Copy link
Contributor Author

Thank you, @Arun8295! (I didn't even know you could test embedded DartPads that way... good sleuthing!)

I've forked your gists here:

https://gist.github.com/kwalrath/70bb4db7bea44663206e7a9c111f31d2
https://gist.github.com/kwalrath/256036008d252d07c9c9d72bd3b03867

All you need to do now is go to the source code for the page that embeds the DartPads (you can get to it by clicking the page icon at the top right, and then the pencil in GitHub) and substitute those numbers for the existing ones. (e.g. portmanteaux_simple should refer to 70bb4db7bea44663206e7a9c111f31d2 instead of the current number.)

@kwalrath
Copy link
Contributor Author

kwalrath commented Oct 3, 2019

#1971 completed the fix for this bug by incorporating these gists into the page.

@kwalrath kwalrath closed this as completed Oct 3, 2019
@kwalrath kwalrath mentioned this issue Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.tut.tutorial Relates to the Tutorial section of dart.dev e1-hours Can complete in < 8 hours of normal, not dedicated, work fix.bug Needs fix of incorrect copy, code, or visual fix.examples Adds or changes example p2-medium Necessary but not urgent concern. Resolve when possible. target.web Target apps on the web platform
Projects
None yet
Development

No branches or pull requests

2 participants