Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go through web tutorials, fix or report any issues #1958

Closed
4 tasks done
kwalrath opened this issue Sep 27, 2019 · 17 comments
Closed
4 tasks done

Go through web tutorials, fix or report any issues #1958

kwalrath opened this issue Sep 27, 2019 · 17 comments
Assignees
Labels
a.tut.tutorial Relates to the Tutorial section of dart.dev co.beginner Community opportunity to make a small change to documentation co.help-wanted Community opportunity to help documentation e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible. target.web Target apps on the web platform

Comments

@kwalrath
Copy link
Contributor

kwalrath commented Sep 27, 2019

We need someone(s) to go through each of the 4 tutorials at https://dart.dev/tutorials/web, reporting/fixing any issues. We especially want to know what's confusing to new Dart devs.

Here are some issues we already know about:

@kwalrath kwalrath added p2-medium Necessary but not urgent concern. Resolve when possible. co.help-wanted Community opportunity to help documentation a.tut.tutorial Relates to the Tutorial section of dart.dev co.beginner Community opportunity to make a small change to documentation e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work target.web Target apps on the web platform labels Sep 27, 2019
@dhanushuUzumaki
Copy link
Contributor

Hello, I would like to take this up.

@kwalrath
Copy link
Contributor Author

Hello, I would like to take this up.

That'd be great! How about you do one (just comment here to say which one you choose) and report back, and we'll decide how to proceed from there. Sound good?

@dhanushuUzumaki
Copy link
Contributor

@kwalrath That's great. I will start with "Fetch Data Dynamically".

@wang-ories
Copy link
Contributor

Hi @kwalrath,
I would like to contribute and I can start with this topic
Connect Dart & HTML

@shreyansh-goyal
Copy link

HI @kwalrath
I would like to take up with "Remove DOM Elements"

@grieff
Copy link

grieff commented Oct 1, 2019

Hi @kwalrath
I'll like to contribute ane check the remaining one, «Add elements to the DOM»

@kwalrath
Copy link
Contributor Author

kwalrath commented Oct 1, 2019

Thank you, all!

@hauze-v
Copy link

hauze-v commented Oct 2, 2019

@kwalrath Do you require anyone else to run through any of the tutorials a second time to receive and further feedback? If so I'd like to contribute.

@kwalrath
Copy link
Contributor Author

kwalrath commented Oct 2, 2019

@MaxRupees we have other tutorials, and it's always to get eyes on them. Would you be interested in running through any of the other tutorials at https://dart.dev/tutorials?

@dhanushuUzumaki
Copy link
Contributor

Hello @kwalrath
I went through the tutorial and found two issues with loading data.

https://dart.dev/tutorials/web/fetch-data#using-getString-function
https://dart.dev/tutorials/web/fetch-data#making-a-get-request

In both cases, the request fails and the data is not loaded. In network monitoring, I see both of those requests as canceled. Should I open an issue?

Regards,
Dhanushu A P

@kwalrath
Copy link
Contributor Author

kwalrath commented Oct 2, 2019

Hello @kwalrath
I went through the tutorial and found two issues with loading data.

https://dart.dev/tutorials/web/fetch-data#using-getString-function
https://dart.dev/tutorials/web/fetch-data#making-a-get-request

In both cases, the request fails and the data is not loaded. In network monitoring, I see both of those requests as canceled. Should I open an issue?

Yes, please. Open an issue with all the details you can easily supply. Thanks!

@shreyansh-goyal
Copy link

"Remove DOM Elements" is working fine

@dhanushuUzumaki
Copy link
Contributor

Hello @kwalrath
I went through the tutorial and found two issues with loading data.
https://dart.dev/tutorials/web/fetch-data#using-getString-function
https://dart.dev/tutorials/web/fetch-data#making-a-get-request
In both cases, the request fails and the data is not loaded. In network monitoring, I see both of those requests as canceled. Should I open an issue?

Yes, please. Open an issue with all the details you can easily supply. Thanks!

Created a new issue #1970

Regards,
Dhanushu A P

@kwalrath
Copy link
Contributor Author

kwalrath commented Oct 4, 2019

@wang-ories and @grieff, could you please update this issue with the results of your assigned web tutorial reviews? Thanks!

@wang-ories
Copy link
Contributor

I worked on Connect Dart & HTML tutorial and I opened issue here : #1966
Thanks,

@grieff
Copy link

grieff commented Oct 4, 2019

I've checked the "Add elements to the DOM" tutorial, and everything is working fine. Also, I doesn't seem to have anything that'll be confusing to new Dart users.

@kwalrath
Copy link
Contributor Author

kwalrath commented Oct 4, 2019

Thanks, everyone! I'm closing this issue.

@kwalrath kwalrath closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.tut.tutorial Relates to the Tutorial section of dart.dev co.beginner Community opportunity to make a small change to documentation co.help-wanted Community opportunity to help documentation e1-hours Can complete in < 8 hours of normal, not dedicated, work e2-days Can complete in < 5 days of normal, not dedicated, work p2-medium Necessary but not urgent concern. Resolve when possible. target.web Target apps on the web platform
Projects
None yet
Development

No branches or pull requests

6 participants