-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go through CL/server tutorials, report/fix issues #1978
Comments
Hello @kwalrath I can work on this tutorial. |
Thanks, @wang-ories! Which one would you like to work on first? |
@wang-ories you get your pick... just tell us which one you're doing, so anyone else who's interested can sign up for another tutorial. |
@kwalrath I take this tutorial : Write command-line apps |
@kwalrath I found two smalls problem in this tutorial: 1 - In this section https://dart.dev/tutorials/server/cmdline#overview-of-the-dcat-app-code : the result of this command $ dart dcat.dart -n quote.txt produces empty output, i.e the file quote.txt must be created first. In the tutorial the output is three quotes from quote.txt.
|
Ah right, back when this was written, there was an in-page link to all the files, including quote.txt. The source is at https://github.com/dart-lang/site-www/blob/master/examples/misc/test_data/quote.txt. Maybe we should just tell people to download it from that location.
Looks like it should be https://api.dart.dev/stable/dart-convert/dart-convert-library.html. |
Ok |
@kwalrath for the link is simple, can I just fix it? |
Yep, go ahead. |
@kwalrath , I can work on this first problem, if not assigned yet. I will add the link to download and tell people to download. |
That would be great. Thank you! |
Hi @kwalrath, |
It's yours! |
Tell people to download quote.txt file and add the link to this file. Contributes to #1978.
I've checked all commands and links into Get started tutorial. Everything seems to work as expected! |
hi can i pick third one ? |
:) :? |
@hamidrezabstn the third one is yours. Thanks! |
@kwalrath |
A quick glance at the code code example is different from github source code Making a POST request from a standalone client client code sample is differ from github version Using the http_server package mini code sample is differ from github version Using https with bindSecure() secure code sample is differ from github version all links are fine |
Thanks very much, @hamidrezabstn. Could you please file one issue for the code sample differences and an issue or PR for the webdev issue? Thanks! |
@kwalrath |
i made a PR at #2021 |
@hamidrezabstn thanks for fixing the sample links! Do you want to take a stab at fixing the webdev issue, or do you want to file an issue about it? |
@kwalrath i'm really sorry about that i totally forget about it ! i will make a PR for it! |
@hamidrezabstn I just noticed that the names of the source files are down below the snippets. E.g. hello_world_server.dart is displayed beneath the first code excerpt (https://dart.dev/tutorials/server/httpserver#a-quick-glance-at-the-code). It looks odd. (I tried looking at it in the wayback machine, but it's having issues with that page. I think the filename used to be displayed on top of the code sample, but I'm thinking that isn't really necessary.) One solution would be to simply remove the lines that have these filenames. E.g. for the first example we might remove this line:
What do you think? |
Maybe during site migration some styles were dropped or overridden. I can take a look first before we strip out filenames. WDYT @kwalrath? |
@kwalrath i think because of file links under each section's title , for example: Example file for this section: hello_world_server.dart. , and referencing that file in different positions in related section, like this
,that file name below snippets is not necessary . |
There are 3 tutorials under https://dart.dev/tutorials/server. We'd like a volunteer for each one, to go through and report/fix issues (similar to #1958).
Known issue:
The text was updated successfully, but these errors were encountered: