Fix #1970 #1971
Merged
Fix #1970 #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to use new Gists (URLs changed to dart.dev)
googlebot
added
the
cla: yes
kwalrath
reviewed
Oct 3, 2019
src/_tutorials/web/fetch-data.md
Outdated
| @@ -414,7 +414,7 @@ and loads the file. | |||
|
|
|||
| **Try it!** Click **Run** and then click the **Get portmanteaux** button. | |||
|
|
|||
| {% comment %} https://gist.github.com/chalin/6b76bce8d46986e624f4e82925c48287 {% endcomment %} | |||
| {% comment %} https://gist.github.com/kwalrath/70bb4db7bea44663206e7a9c111f31d2 {% endcomment %} | |||
| <iframe | |||
| src="{{site.dartpad-embed-html}}?id=6b76bce8d46986e624f4e82925c48287" | |||
There was a problem hiding this comment.
You need to update 6b76bce8d46986e624f4e82925c48287 in this line to be 70bb4db7bea44663206e7a9c111f31d2 instead.
There was a problem hiding this comment.
Oops Sorry I just saw the comment tag around that. Will update.
kwalrath
reviewed
Oct 3, 2019
src/_tutorials/web/fetch-data.md
Outdated
| @@ -470,7 +470,7 @@ and use the [send()][] method to make the request. | |||
| This section rewrites the portmanteaux code to explicitly construct | |||
| an HttpRequest object. | |||
|
|
|||
| {% comment %} https://gist.github.com/chalin/c387e454cb751ab0632c68ccbbf94d12 {% endcomment %} | |||
| {% comment %} https://gist.github.com/kwalrath/f8aa7310e96d359c5f68343c9ccba8ed {% endcomment %} | |||
| <iframe | |||
| src="{{site.dartpad-embed-html}}?id=c387e454cb751ab0632c68ccbbf94d12" | |||
There was a problem hiding this comment.
c387e454cb751ab0632c68ccbbf94d12 -> f8aa7310e96d359c5f68343c9ccba8ed
kwalrath
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
LGTM!
I've confirmed that it works in the staged version: https://kw-staging-dartlang-2.firebaseapp.com/tutorials/web/fetch-data#using-getString-function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use new Gists (URLs changed to dart.dev)