Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistaken link formatting at end of the 'Dart SDK overview' page #5942

Closed
1 task
bdaler opened this issue Jun 27, 2024 · 0 comments · Fixed by #5945
Closed
1 task

Fix mistaken link formatting at end of the 'Dart SDK overview' page #5942

bdaler opened this issue Jun 27, 2024 · 0 comments · Fixed by #5945
Assignees
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.link Adds, changes, or removes a link to a page from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged

Comments

@bdaler
Copy link

bdaler commented Jun 27, 2024

Page URL

https://dart.dev/tools/sdk/

Page source

https://github.com/dart-lang/site-www/tree/main/src/content/tools/sdk.md

Describe the problem

Wrong url to "readme" and "the SDK issue tracker" on bottom of page . Returning 404

image
image

Expected fix

No response

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on dart.dev.
@bdaler bdaler added the from.page-issue Reported in a reader-filed concern label Jun 27, 2024
@atsansone atsansone added p2-medium Necessary but not urgent concern. Resolve when possible. e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.link Adds, changes, or removes a link to a page st.triage.ltw Indicates Lead Tech Writer has triaged labels Jun 27, 2024
@atsansone atsansone self-assigned this Jun 27, 2024
@atsansone atsansone changed the title [PAGE ISSUE]: 'Dart SDK overview' Fix mistaken link formatting at end of the 'Dart SDK overview' page Jun 27, 2024
atsansone added a commit that referenced this issue Jun 27, 2024
Fixes #5942 

Links at the bottom of the page were formatted as inline Markdown links instead of reference links.
atsansone added a commit to atsansone/site-www that referenced this issue Jul 18, 2024
Fixes dart-lang#5942 

Links at the bottom of the page were formatted as inline Markdown links
instead of reference links.

---

- [ ] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.
- [ ] This PR doesn't contain automatically generated corrections or
text (Grammarly, LLMs, and similar).
- [ ] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [ ] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https://github.com/dart-lang/site-www/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Code changes should generally follow the [Dart style
guide](https://dart.dev/effective-dart) and use `dart format`.
- Updates to [code
excerpts](https://github.com/dart-lang/site-shared/blob/main/doc/code-excerpts.md)
indicated by `<?code-excerpt` need to be updated in their source `.dart`
file as well.
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work fix.link Adds, changes, or removes a link to a page from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants