Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub links on SDK page #5945

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Update GitHub links on SDK page #5945

merged 1 commit into from
Jun 27, 2024

Conversation

atsansone
Copy link
Contributor

@atsansone atsansone commented Jun 27, 2024

Fixes #5942

Links at the bottom of the page were formatted as inline Markdown links instead of reference links.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

Fixes #5942 

Links at the bottom of the page were formatted as inline Markdown links instead of reference links.
@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 0e0aa9a):

https://dart-dev--pr5945-fix-5942-2um85t01.web.app

@atsansone atsansone merged commit 3e126eb into main Jun 27, 2024
10 checks passed
@parlough parlough deleted the fix-5942 branch June 27, 2024 16:57
atsansone added a commit to atsansone/site-www that referenced this pull request Jul 18, 2024
Fixes dart-lang#5942 

Links at the bottom of the page were formatted as inline Markdown links
instead of reference links.

---

- [ ] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.
- [ ] This PR doesn't contain automatically generated corrections or
text (Grammarly, LLMs, and similar).
- [ ] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [ ] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https://github.com/dart-lang/site-www/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Code changes should generally follow the [Dart style
guide](https://dart.dev/effective-dart) and use `dart format`.
- Updates to [code
excerpts](https://github.com/dart-lang/site-shared/blob/main/doc/code-excerpts.md)
indicated by `<?code-excerpt` need to be updated in their source `.dart`
file as well.
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mistaken link formatting at end of the 'Dart SDK overview' page
3 participants