Bump min Dart version to 3.4.0 for WASM #2242
Conversation
Before 3.4.0: ```console Could not find an option with short name "-O". Usage: dart compile wasm [arguments] <dart entry point> ``` This option was added in commit [92d53c426f9b4764e5c34d33ef7bbcf5fd3b12a6](dart-lang/sdk@92d53c4)
|
Thanks, unfortunately we can't fix this for the old published versions, and are past the retraction window for 1.25.6. Because of that I won't bother publishing this change right now, but we should land it nonetheless (users on old SDKs would still just end up getting the old, broken version anyways). |
|
adding @natebosch for additional review since I pushed a bunch of other related changes here |
|
Should we update CI to run at the lowest resolvable Dart SDK version to avoid this in the future? |
It does already - the problem is wasm is tested through the We should also add at least a basic wasm test in the actual |
|
Getting some weird failures here on windows... I am not sure what the issue is. If they are reproducing at HEAD we can still land this though, which I will check. |
|
It looks like these failures are a result of the change to running on We will separately address this problem, landing this for now, on red. |
…ser, path, shelf, test, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. async (https://github.com/dart-lang/async/compare/4073129..a004370): a004370 2024-06-10 Kevin Moore Bump min SDK, tighten dependencies, test wasm on 3.4 (dart-archive/async#277) convert (https://github.com/dart-lang/convert/compare/70940e3..0c9eab7): 0c9eab7 2024-06-10 Kevin Moore latest lints, require Dart 3.4 (dart-archive/convert#107) crypto (https://github.com/dart-lang/crypto/compare/7a9428a..813e35e): 813e35e 2024-06-10 Kevin Moore Update min SDK, test wasm on 3.4 (dart-archive/crypto#174) dartdoc (https://github.com/dart-lang/dartdoc/compare/3decf1e..14d33d3): 14d33d3a 2024-06-12 Sam Rawlins Fix referencing an aliased type parameter. (dart-lang/dartdoc#3784) 12d271a5 2024-06-10 Sam Rawlins Combine the two implementations of "library canonicalization" (dart-lang/dartdoc#3781) ca61935e 2024-06-10 Sam Rawlins Revert "Deprecate --resources-dir option. (`#3696`)" (dart-lang/dartdoc#3782) ecosystem (https://github.com/dart-lang/ecosystem/compare/865b2c5..b2b045f): b2b045f 2024-06-12 Devon Carew remove extraneous quotes (dart-lang/ecosystem#270) fdedf3c 2024-06-11 Devon Carew move to logging; check for safety exceptions (dart-lang/ecosystem#269) 27574e0 2024-06-10 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/ecosystem#268) 6e53c96 2024-06-10 Devon Carew updates for the blast_repo tool (dart-lang/ecosystem#267) http (https://github.com/dart-lang/http/compare/b522000..e2e2170): e2e2170 2024-06-11 David Wimmer Update README.md (dart-lang/http#1231) f8d5bf8 2024-06-12 Anikate De [pkgs/ok_http] Add functionality to accept and configure redirects. (dart-lang/http#1230) 93ff4a9 2024-06-11 Anikate De [ok_http]: Use the Android SDK to generate JNI bindings. (dart-lang/http#1229) http_parser (https://github.com/dart-lang/http_parser/compare/551e0e4..53d4041): 53d4041 2024-06-10 Kevin Moore blast_repo fixes (dart-archive/http_parser#98) 1ff06e4 2024-06-10 Kevin Moore Update min SDK, test wasm on 3.4 (dart-archive/http_parser#97) path (https://github.com/dart-lang/path/compare/8fc4c72..04807b6): 04807b6 2024-06-10 Kevin Moore Update to latest lints, bump min SDK to 3.4, test wasm on 3.4 (dart-archive/path#168) shelf (https://github.com/dart-lang/shelf/compare/ea3c983..4c54af6): 4c54af6 2024-06-11 Kevin Moore [shelf_test_handler] Bump dev deps (dart-lang/shelf#435) test (https://github.com/dart-lang/test/compare/83c597e..329c6df): 329c6dff 2024-06-10 Jacob MacDonald fix windows failures (dart-lang/test#2244) 777631bb 2024-06-10 Rexios Bump min Dart version to 3.4.0 for WASM (dart-lang/test#2242) webdev (https://github.com/dart-lang/webdev/compare/9ada46f..eccc7d8): eccc7d87 2024-06-12 Parker Lougheed Update `package:lints` and clean up library declarations (dart-lang/webdev#2436) Change-Id: Ic7aede173c9730f0ccd1bc3138f50a92ddf49fce Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371440 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Before 3.4.0:
This option was added in commit 92d53c426f9b4764e5c34d33ef7bbcf5fd3b12a6