Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix referencing an aliased type parameter. #3784

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix referencing an aliased type parameter. #3784

merged 1 commit into from
Jun 12, 2024

Conversation

srawlins
Copy link
Member

What is an aliased type parameter? Good question! typedef TD<T> = T; is such an alias. The fix is pretty simple, we just weren't previously handling this case, or being safe.

Fixes #3783

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins
Fix referencing an aliased type parameter.
5824438 
What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
an alias. The fix is pretty simple, we just weren't previously handling this
case, or being safe.
@srawlins
Copy link
Member Author

CC @dart-lang/analyzer-team

kallentu
kallentu approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@kallentu kallentu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking at this briefly yesterday when @srujzs told me about it.
Thanks for making the fix for this super fast!

@srawlins
Copy link
Member Author

Thanks!

@srawlins srawlins merged commit 14d33d3 into dart-lang:main Jun 12, 2024
9 checks passed
@srawlins srawlins deleted the fix-alias-to-type-parameter branch June 12, 2024 21:53
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 13, 2024
@devoncarew
[deps] rev async, convert, crypto, dartdoc, ecosystem, http, http_par…
1a45349 
…ser, path, shelf, test, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/4073129..a004370):
  a004370  2024-06-10  Kevin Moore  Bump min SDK, tighten dependencies, test wasm on 3.4 (dart-archive/async#277)

convert (https://github.com/dart-lang/convert/compare/70940e3..0c9eab7):
  0c9eab7  2024-06-10  Kevin Moore  latest lints, require Dart 3.4 (dart-archive/convert#107)

crypto (https://github.com/dart-lang/crypto/compare/7a9428a..813e35e):
  813e35e  2024-06-10  Kevin Moore  Update min SDK, test wasm on 3.4 (dart-archive/crypto#174)

dartdoc (https://github.com/dart-lang/dartdoc/compare/3decf1e..14d33d3):
  14d33d3a  2024-06-12  Sam Rawlins  Fix referencing an aliased type parameter. (dart-lang/dartdoc#3784)
  12d271a5  2024-06-10  Sam Rawlins  Combine the two implementations of "library canonicalization" (dart-lang/dartdoc#3781)
  ca61935e  2024-06-10  Sam Rawlins  Revert "Deprecate --resources-dir option. (`#3696`)" (dart-lang/dartdoc#3782)

ecosystem (https://github.com/dart-lang/ecosystem/compare/865b2c5..b2b045f):
  b2b045f  2024-06-12  Devon Carew  remove extraneous quotes (dart-lang/ecosystem#270)
  fdedf3c  2024-06-11  Devon Carew  move to logging; check for safety exceptions (dart-lang/ecosystem#269)
  27574e0  2024-06-10  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/ecosystem#268)
  6e53c96  2024-06-10  Devon Carew  updates for the blast_repo tool (dart-lang/ecosystem#267)

http (https://github.com/dart-lang/http/compare/b522000..e2e2170):
  e2e2170  2024-06-11  David Wimmer  Update README.md (dart-lang/http#1231)
  f8d5bf8  2024-06-12  Anikate De  [pkgs/ok_http] Add functionality to accept and configure redirects. (dart-lang/http#1230)
  93ff4a9  2024-06-11  Anikate De  [ok_http]: Use the Android SDK to generate JNI bindings. (dart-lang/http#1229)

http_parser (https://github.com/dart-lang/http_parser/compare/551e0e4..53d4041):
  53d4041  2024-06-10  Kevin Moore  blast_repo fixes (dart-archive/http_parser#98)
  1ff06e4  2024-06-10  Kevin Moore  Update min SDK, test wasm on 3.4 (dart-archive/http_parser#97)

path (https://github.com/dart-lang/path/compare/8fc4c72..04807b6):
  04807b6  2024-06-10  Kevin Moore  Update to latest lints, bump min SDK to 3.4, test wasm on 3.4 (dart-archive/path#168)

shelf (https://github.com/dart-lang/shelf/compare/ea3c983..4c54af6):
  4c54af6  2024-06-11  Kevin Moore  [shelf_test_handler] Bump dev deps (dart-lang/shelf#435)

test (https://github.com/dart-lang/test/compare/83c597e..329c6df):
  329c6dff  2024-06-10  Jacob MacDonald  fix windows failures (dart-lang/test#2244)
  777631bb  2024-06-10  Rexios  Bump min Dart version to 3.4.0 for WASM (dart-lang/test#2242)

webdev (https://github.com/dart-lang/webdev/compare/9ada46f..eccc7d8):
  eccc7d87  2024-06-12  Parker Lougheed  Update `package:lints` and clean up library declarations (dart-lang/webdev#2436)

Change-Id: Ic7aede173c9730f0ccd1bc3138f50a92ddf49fce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371440
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
srawlins added a commit to srawlins/dartdoc that referenced this pull request Jun 27, 2024
@srawlins
Fix referencing an aliased type parameter. (dart-lang#3784)
8d8a1a0 
What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
an alias. The fix is pretty simple, we just weren't previously handling this
case, or being safe.
This was referenced Jun 27, 2024
Closed
Merged
srawlins added a commit to srawlins/dartdoc that referenced this pull request Jun 27, 2024
@srawlins
Fix referencing an aliased type parameter. (dart-lang#3784)
91d909e 
What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
an alias. The fix is pretty simple, we just weren't previously handling this
case, or being safe.
srawlins added a commit to srawlins/dartdoc that referenced this pull request Jun 27, 2024
@srawlins
Fix referencing an aliased type parameter. (dart-lang#3784)
510c210 
What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
an alias. The fix is pretty simple, we just weren't previously handling this
case, or being safe.
srawlins added a commit to srawlins/dartdoc that referenced this pull request Jun 27, 2024
@srawlins
Fix referencing an aliased type parameter. (dart-lang#3784)
36db497 
What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
an alias. The fix is pretty simple, we just weren't previously handling this
case, or being safe.
srawlins added a commit that referenced this pull request Jun 27, 2024
@srawlins @scheglov
Cherry-pick #3784 into an 8.0.9+1 release (#3800)
fb40d2b 
4 cherry-picks + a version bump:

1. cherry-pick 8be17e1

    Fix flutter CI with re-internalized snippets tool (#3776)

2. cherry-pick ae1f184

    Use package:analyzer/source/source.dart (#3780)

3. cherry-pick db3a0ec

    Restrict validation of runtime renderer files to a single, target version of (#3778)
    the analyzer package.

4. cherry-pick 36db497

    Fix referencing an aliased type parameter. (#3784)

    What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such
    an alias. The fix is pretty simple, we just weren't previously handling this
    case, or being safe.

5. Bump to 8.0.9+1

---------

Co-authored-by: Konstantin Scheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kallentu kallentu kallentu approved these changes

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@srawlins @bwilkerson @kallentu