Fix hang after multiple precompiled browser tests #2422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2294
Avoid creating extra unexpected BrowserManager instances by caching the
future in the
_browserManagers
map without any async delay. Previouslyit was possible for two managers to be created if the second suite is
loaded before the first suite's
compilerSupport
was resolved. This wasnot a problem for tests that get compiled by the test runner because the
compilation would delay the second suite load until after the first
suite's
compilerSupport
has resolved. It is not a problem when runningwithout concurrency because that delays the second suite load.
Add a concurrency argument to the regression test, otherwise the default
is to run with concurrency 1 which works around the bug.