Partial fix for benchmarks. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Dec 8, 2024
|
@PlugFox just two analyzer infos that needs to be fixed |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 9, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. core (https://github.com/dart-lang/core/compare/abcf992..7f9f597): 7f9f597e 2024-12-03 Devon Carew update the pubspec version of package:collection (dart-lang/core#730) ecosystem (https://github.com/dart-lang/ecosystem/compare/248b180..b4b2a43): b4b2a43 2024-12-06 Moritz Unsubmit donotsubmit (dart-lang/ecosystem#324) 8749a2b 2024-12-06 Moritz Updates to `health.yaml` (dart-lang/ecosystem#310) 10fb2c0 2024-12-05 Moritz Ecosystem testing (dart-lang/ecosystem#320) test (https://github.com/dart-lang/test/compare/2096773..dc0f8ea): dc0f8ea4 2024-12-04 Nate Bosch Fix hang after multiple precompiled browser tests (dart-lang/test#2422) tools (https://github.com/dart-lang/tools/compare/1c5b8b9..223daf5): 223daf53 2024-12-05 Ben Konyi Update `package:vm_service` constraints to >=12.0.0 <16.0.0 (dart-lang/tools#1205) vector_math (https://github.com/google/vector_math.dart/compare/433fb6c..bd4b574): bd4b574 2024-12-09 Plague Fox Partial fix for benchmarks (google/vector_math.dart#337) Change-Id: Ie5ce1e95647ac19af1dcfd1d5ee495659052ddc9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399701 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for benchmarks.
The thing is that in some microbenchmarks the calculation result is not used in any way, because of this the compiler simply "optimizes the benchmark" by throwing away the payload.
Most of the current benchmark implementations literally measure the air in an empty room.
I can only partially fix them, I think for further fixes you should ask Vyacheslav Egorov for advice.
https://mrale.ph/blog/2021/01/21/microbenchmarking-dart-part-1.html
https://mrale.ph/blog/2024/11/27/microbenchmarks-are-experiments.html