Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for build_runner build #3

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Conversation

nshahan
Copy link
Contributor

@nshahan nshahan commented Jan 11, 2018

Simply passes all args to build_runner.

Simply passes all args to build_runner.
@nshahan nshahan requested a review from alorenzen January 11, 2018 00:51
Copy link
Contributor

@alorenzen alorenzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Actually passing all arguments was awkward because messages didn't reference webdev and args had to be passed with an extra `--`.
@nshahan nshahan merged commit 9dd2045 into master Jan 11, 2018
@nshahan nshahan deleted the add-build-command branch January 11, 2018 23:05
@J4ckTh3R1qp3r J4ckTh3R1qp3r mentioned this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants