Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midpoint test fails #3

Closed
baparham opened this issue Nov 6, 2020 · 1 comment
Closed

Midpoint test fails #3

baparham opened this issue Nov 6, 2020 · 1 comment

Comments

@baparham
Copy link
Member

baparham commented Nov 6, 2020

Running from the current master (80ce30b), on Windows, with dart version:
Dart SDK version: 2.10.0-7.3.beta (beta) (Wed Aug 26 09:46:50 2020 +0200) on "windows_x64"

Does this test pass for you folks? Perhaps on Linux or on another dart version?

Log output:

PS C:\git\turf_dart> dart test
Precompiling executable...
Precompiled test:test.
00:05 +1: test\components\midpoint_test.dart: midpoint
29.704243058393104
251.6519826898071
289.2560026566121, 326.5268244185807, 0
00:06 +9 -1: test\components\midpoint_test.dart: midpoint [E]
  Expected: <true>
    Actual: <false>

  package:test_api                         expect
  test\components\midpoint_test.dart 24:5  main.<fn>

00:06 +17 -1: Some tests failed.

Thanks!
I'll keep looking at it to see if I can find a bug in the implementation, or in the test.

lukas-h added a commit that referenced this issue Nov 7, 2020
@lukas-h
Copy link
Member

lukas-h commented Nov 7, 2020

midpoint tests work now, because I added the normalization of latitudes (antimeridian, meridian boundaries [180;-180])

see

Position.toSigned()

@lukas-h lukas-h closed this as completed Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants