Port midpoint tests from turf.js #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Midpoint tests taken from https://github.com/Turfjs/turf commit SHA 23d5cb91d77e0c1e2e903a2252f525797f1d0d09
baparham
commented
Nov 7, 2020
| ); | ||
| Point result = midpoint(pt1, pt2); | ||
|
|
||
| checkLatLngInRange(result); |
There was a problem hiding this comment.
I think this test is actually missing the distance check that the other tests have, which also perhaps could be pulled out into a separate function, like checkLatLngInRange. I'll keep the fix on hold in case there is other feedback that should be addressed in another patch.
|
Hi @baparham, thanks for the pull request, there is not directly a bug in the implementation but it's due to a lack of normalization of coordinates (meridian/antimeridian boundaries) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Midpoint tests taken from https://github.com/Turfjs/turf commit SHA
23d5cb91d77e0c1e2e903a2252f525797f1d0d09 (the current
mastercommit as of writing)Spawned by test failure referenced in issue #3
Basically a direct port of the turf.js tests, with the addition of the existing lat/lng in range check the existing turf_dart test had.
Two of these tests still fail, but perhaps that points to an implementation bug in
midpoint. It seemed starting with the turf.js tests would help identify if there was in fact a bug in the implementation.