3 memory leaks in mesh loading

[Aneoshun]

Bug Report

Please answer the following questions for yourself before submitting an issue.

• I checked the documentation and found no answer.
• I checked to make sure that this issue has not already been filed.

Environment

• DART version: master
• OS name and version name(or number): Ubuntu 16.04
• compiler name and version number: GCC 5.4

Hi all,

I have identified 3 leaks coming from the usage of Assimp's API.

1. In the destructor of MeshShape, delete mMesh; should be replaced by aiReleaseImport(mMesh); . The reason is that the memory associated to this mesh is stored and managed by the Importer used to create this mesh, aiReleaseImport will clean all this for you. See here http://assimp.sourceforge.net/lib_html/usage.html
   

   dart/dart/dynamics/MeshShape.cpp

   Line 148 in 36a6a48

   delete mMesh;

2. The propertyStore instanciated here
   

   dart/dart/dynamics/MeshShape.cpp

   Line 358 in 36a6a48

   aiPropertyStore* propertyStore = aiCreatePropertyStore();

   
   is never freed. I suggest to add aiReleasePropertyStore(propertyStore); at the end of the loadMesh function.

3. The aiFile instanciated here
   

   dart/dart/dynamics/AssimpInputResourceAdaptor.cpp

   Line 247 in 36a6a48

   aiFile* out = new aiFile;

   
   is not freed by the close protocol .
   I have added delete _file; after this line
   

   dart/dart/dynamics/AssimpInputResourceAdaptor.cpp

   Line 261 in 36a6a48

   getIOSystem(_io)->Close(getIOStream(_file));

   
   and it solves my memory leaks issue.

After fixing these 3 leaks (plus one directly in Assimp assimp/assimp#1934 ) I have no more memory leak according to valgrind.
Let me know if you need more details.

I hope this will help you.

[jslee02]

Appreciated for the detailed report. #1066 is created to fix the memory leaks.

[Aneoshun]

Thanks!