Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in mesh loading #1066

Merged
merged 2 commits into from
May 4, 2018
Merged

Fix memory leaks in mesh loading #1066

merged 2 commits into from
May 4, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 3, 2018

This PR fixes the memory leaks reported in #1063.


Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md

@jslee02 jslee02 added this to the DART 6.5.0 milestone May 3, 2018
@jslee02 jslee02 mentioned this pull request May 3, 2018
2 tasks
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #1066 into release-6.5 will decrease coverage by 0.08%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release-6.5    #1066      +/-   ##
===============================================
- Coverage        56.61%   56.52%   -0.09%     
===============================================
  Files              316      316              
  Lines            24393    24396       +3     
===============================================
- Hits             13809    13790      -19     
- Misses           10584    10606      +22
Impacted Files Coverage Δ
dart/dynamics/MeshShape.cpp 48.12% <100%> (-13.27%) ⬇️
dart/dynamics/AssimpInputResourceAdaptor.cpp 56.32% <100%> (+0.5%) ⬆️

@jslee02 jslee02 merged commit d79d04c into release-6.5 May 4, 2018
@jslee02 jslee02 deleted the bugfix/memory_leaks branch May 4, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant