Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision detectors should refresh collision shapes when they get changed #368

Closed
mxgrey opened this issue Mar 26, 2015 · 5 comments
Closed
Assignees
Labels
priority: high should be resolved right now tag: feature request Indicates new feature requests

Comments

@mxgrey
Copy link
Member

mxgrey commented Mar 26, 2015

Based on what I've looked through in the source code, it seems like the FCLCollisionDetector classes only grab the Shape information when a Skeleton is first given to it. This could pose a problem if a collision shape is ever added or removed (or even modified). It would be good if the fcl::CollisionGeometry data structures could be updated as Shapes change and added/removed as Shapes are added and removed from the BodyNode's collision shape array.

This could either be implemented with dirty flags or with the recent Signal/Slog feature that's been added.

Note that this does not appear to be an issue for the DARTCollide class.

@mxgrey mxgrey added priority: medium should be resolved before the next release Kind: Feature Request priority: low no timeline yet and removed priority: medium should be resolved before the next release labels Mar 26, 2015
@jslee02
Copy link
Member

jslee02 commented Mar 26, 2015

Agree, and there is similar issue, #197.

@mxgrey
Copy link
Member Author

mxgrey commented Apr 28, 2015

To add to this, the collision detectors should update whenever a new BodyNode is added to a Skeleton. I'm noticing that the collision handler behaves poorly when BodyNodes are created or removed from a Skeleton unless you remove the Skeleton and re-add it.

@jslee02
Copy link
Member

jslee02 commented Apr 16, 2016

Related to #664

@jslee02 jslee02 added tag: feature request Indicates new feature requests and removed Kind: New feature labels Oct 17, 2016
@stale
Copy link

stale bot commented Feb 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 13, 2018
@stale stale bot removed the stale label Feb 13, 2018
@mxgrey mxgrey added priority: high should be resolved right now and removed priority: low no timeline yet labels Sep 14, 2018
@mxgrey mxgrey self-assigned this Sep 14, 2018
@jslee02
Copy link
Member

jslee02 commented Apr 22, 2021

Resolved by #1112

@jslee02 jslee02 closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high should be resolved right now tag: feature request Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants