Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically updating CollisionGroups when ShapeNodes are added/removed #664

Closed
mxgrey opened this issue Apr 13, 2016 · 2 comments
Closed
Assignees

Comments

@mxgrey
Copy link
Member

mxgrey commented Apr 13, 2016

  1. Currently a CollisionGroup will only pay attention to the ShapeNodes on a BodyNode or Skeleton that are present at the moment that they are handed over. It would be good if they could update automatically whenever the ShapeNodes are altered in some way. We could possibly do this with a wrapper class or build the functionality into CollisionGroup itself.
  2. CollisionGroup currently does not know when a ShapeFrame it refers to gets destroyed. This can leave the CollisionGroup in an undefined state and lead to undesirable behavior.
@stale
Copy link

stale bot commented Feb 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 13, 2018
@stale stale bot removed the stale label Feb 13, 2018
@mxgrey mxgrey self-assigned this Sep 17, 2018
@jslee02
Copy link
Member

jslee02 commented Nov 11, 2018

I believe this is resolved by #1112

@jslee02 jslee02 closed this as completed Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants