Packaging 6.7.0 #1215
Merged
Packaging 6.7.0 #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0b5b6dd.
5 tasks
jslee02
pushed a commit
that referenced
this pull request
Jan 10, 2019
#1216) I recently needed to make a real-time simulation display on top of dartsim, so I decided to clean it up and add it into the main repo since it's a frequently requested feature (e.g. #1204). It's a simple wrapper on top of the `dart::gui::osg::WorldNode` class. Users can opt for either the old `WorldNode` or the new `RealTimeWorldNode` depending on how they want to control the speed of the simulation. I also added a line `ImGui::CreateContext();` because ImGui was crashing without that. I know #1215 has already been opened, so I can retarget this at a `6.8` release (or we can wait until 6.7.1 since this won't impact API or ABI) instead if that would be preferred. *** **Before creating a pull request** - [x] Document new methods and classes - [x] Format new code files using `clang-format` **Before merging a pull request** - [x] Set version target by selecting a milestone on the right side - [x] Summarize this change in `CHANGELOG.md` - [ ] (N/A) Add unit test(s) for this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1214