Update ClangFormat to version 6.0 #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxgrey
previously approved these changes
Jan 11, 2019
2 tasks
jslee02
added a commit
that referenced
this pull request
Jan 12, 2019
FLANN requires `lz4` to be linked, but it's not explicitly linked by the upstream. Depends on #1220 *** **Before merging a pull request** - [x] Set version target by selecting a milestone on the right side - [x] Summarize this change in `CHANGELOG.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a specific version of ClangFormat because different version can format the code differently even with the same configuration. In this PR, we update the ClangFormat version to 6.0. I particularly chose 6.0 because it's the highest version that is available on the Ubuntu distros we support for DART >= 6.8.
Before creating a pull request
clang-formatBefore merging a pull request