Consistent Jacobian and its derivatives of BallJoint and FreeJoint #284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request change the computation of the Jacobians and Jacobian derivatives in consistent way. Previously, the generalized velocities and accelerations of
BallJoint
andFreeJoint
were the spatial velocities and spatial accelerations, which are relative velocities and accelerations between the parent body node and the child body node, so their Jacobians and its derivatives were identity and zero matrices, respectively. The benefit of doing so is that the Jacobians and its derivatives don't need to be computed over simulation steps but the problem is that the velocities, accelerations, Jacobians and Jacobian derivatives are not consistent with the generalized coordinates.Note that the target branch of this PR is release-4.2.