Fixing issue #47 and adding PlanarJoint support for URDFs #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| joint = new dynamics::PlanarJoint(); | ||
| // TODO(MXG): Should we read in position limits? The URDF limits | ||
| // specification only offers one dimension of limits, but a PlanarJoint is | ||
| // two-dimensional. Should we assume that position limits apply to both |
There was a problem hiding this comment.
Actually, it's three-dimensional; x, y, and theta.
Let's not to accept the position limits for now. Can you create an issue for this?
|
+1 |
jslee02
added a commit
that referenced
this pull request
Feb 4, 2015
Fixing issue #47 and adding PlanarJoint support for URDFs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.