Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lemke fails several LCP problems with release-5.1 (tag 5.1.5) #808

Merged
merged 3 commits into from
Oct 29, 2016

Conversation

ytian81
Copy link

@ytian81 ytian81 commented Oct 28, 2016

Hi JS,

I have cleaned up my fix and provide a unit test for it. Please check testLemke.cpp in the unittest folder. You will find that the original implementation fails my unittest, while my fix should work.

Yang


This change is Reviewable

@jslee02
Copy link
Member

jslee02 commented Oct 28, 2016

I haven't investigated the logic of Lemke, but it seems convincing as it passes the tests. I'll wait for 1 or 2 days looking for comments from others before merging this PR. Thanks!

@jslee02 jslee02 added this to the DART 5.1.5 milestone Oct 28, 2016
@jslee02 jslee02 merged commit bf0549f into dartsim:release-5.1 Oct 29, 2016
@psigen
Copy link
Collaborator

psigen commented Oct 30, 2016

@jslee02 can we do a followup cleanup PR? The fix seems alright, but there are a lot of unnecessary syntax and whitespace changes in here that diverge from DART style a bit.

@jslee02
Copy link
Member

jslee02 commented Oct 30, 2016

I agree with you. Let me do that when I have a chance.

I hope we have a guideline for the code style with clang-format setting soon. :)

@ytian81
Copy link
Author

ytian81 commented Nov 2, 2016

Sorry about the formatting issue. I just used my IDE's auto-reformatting tool which is clearly not DART's convention. Thanks for cleaning up the code. BTW, this PR could also be cherry-picked for release-6.1 since its Lemke implementation is the same as release-5.1.

jslee02 added a commit that referenced this pull request Nov 4, 2016
Fix Lemke LCP solver -- #808 for DART 6.2
@ytian81 ytian81 deleted the Lemke_fix branch January 28, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants