SdfParser <use_parent_model_frame> tag #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
approved these changes
Jul 15, 2017
Codecov Report
@@ Coverage Diff @@
## master #893 +/- ##
=======================================
Coverage 50.61% 50.61%
=======================================
Files 299 299
Lines 23409 23409
Branches 3015 3015
=======================================
Hits 11849 11849
Misses 10230 10230
Partials 1330 1330
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a Gazebo plugin that uses DART, I noticed that
SdfParser::readSekeletonincorrectly loads sdf models that have the<use_parent_model_frame>tag enabled. The problem is that the parser applies an isometry to joint axes marked with the tag while only a rotation should be applied. This PR modifiesSdfParser::readAxisElementto only use the rotational component of the isometry.