Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing handling of use_parent_model_frame tag in SdfParser (#893) #901

Closed
wants to merge 1 commit into from

Conversation

scpeters
Copy link
Collaborator

@scpeters scpeters commented Aug 4, 2017

Backport #893 from master to release-6.2

@jslee02
Copy link
Member

jslee02 commented Aug 4, 2017

#893 was actually for 6.2.1 where currently release-6.2 branch is for it.

Sorry, I've been unclear that master branch was for which version. It used to be for 6.3 and now 6.2.1. To fix this, let me:

  • merge master into release-6.2 so that all the patches for 6.2.1 that was merged to master to be applied to release-6.2
  • bump up the version of master to 6.3.0. This could be 7.0 if necessary (by adding API breaking changes).

unless there is an objection.

Once these are done, we might don't need this PR.

@scpeters
Copy link
Collaborator Author

scpeters commented Aug 4, 2017

ok, sorry I didn't know what was on the master branch. I was just trying to see when the changes from #893 will be released

@scpeters
Copy link
Collaborator Author

scpeters commented Aug 4, 2017

feel free to close this when you have sorted out the release branches, and I'll be interested to know when you have time to make another release

@codecov
Copy link

codecov bot commented Aug 4, 2017

Codecov Report

Merging #901 into release-6.2 will not change coverage.
The diff coverage is 0%.

@@             Coverage Diff              @@
##           release-6.2     #901   +/-   ##
============================================
  Coverage        50.59%   50.59%           
============================================
  Files              299      299           
  Lines            23408    23408           
  Branches          3015     3015           
============================================
  Hits             11843    11843           
  Misses           10236    10236           
  Partials          1329     1329
Impacted Files Coverage Δ
dart/utils/sdf/SdfParser.cpp 53.61% <0%> (ø) ⬆️

@jslee02
Copy link
Member

jslee02 commented Aug 6, 2017

Closing this PR as #902 merged. I'm considering releasing 6.2.1 by this week.

@jslee02 jslee02 closed this Aug 6, 2017
@jslee02
Copy link
Member

jslee02 commented Aug 8, 2017

@scpeters FYI, DART 6.2.1 is released including the debian packages and the homebrew formulae.

@jslee02 jslee02 deleted the backport_parent_model_frame branch February 27, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants