Adding setter and getter for WeldJointConstraint::mRelativeTransform #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
approved these changes
Aug 25, 2017
Codecov Report
@@ Coverage Diff @@
## release-6.3 #910 +/- ##
===============================================
- Coverage 50.63% 50.62% -0.01%
===============================================
Files 299 299
Lines 23411 23415 +4
Branches 3016 3016
===============================================
Hits 11854 11854
- Misses 10226 10230 +4
Partials 1331 1331
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any reason to restrict access to setting mRelativeTransform. I also couldn't identify any other data members who would be impacted by changing mRelativeTransform, so the setter is just a straightforward copy.
This addresses #903.