Switch to vcpkg for installing DART dependencies on Windows #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxgrey
reviewed
Sep 5, 2017
|
|
||
| # specify custom environment variables | ||
| # | ||
| # We generate project files for Visual Studio 14 because the boost binaries installed on the test server are for Visual Studio 14. |
There was a problem hiding this comment.
I'm a bit confused. This line says we generate project files for Visual Studio 14, but then above and below it looks like everything is targeting Visual Studio 15. Am I misunderstanding what it's saying about generating project files?
There was a problem hiding this comment.
This is an outdated description. Let me update this accordingly. Probably we don't need this note because boost will be installed anyway as fcl is dependent on it.
|
It seems the building time exceeds the Appveyor limit (1 hour). I guess we need to use a prebuilt image using docker. Let me close this PR until then. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've managed and provided own installer for the DART dependencies, which was tedious work. As discussed, this PR hands over the duty to
vcpkg, which is a package manager for Windows developed by Microsoft.Note that we still don't build DART on Windows until the existing build issues are resolved. This PS only changes the way to install the DART dependencies.