Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render texture images when available #973

Merged
merged 12 commits into from
Feb 13, 2018
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 5, 2018

Before:
image

After:
image

Depends on #972
Resolves #965


Before creating a pull request

  • Document new methods and classes

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.4.0 milestone Feb 5, 2018
@jslee02 jslee02 requested a review from mxgrey February 5, 2018 08:35
@jslee02 jslee02 mentioned this pull request Feb 5, 2018
@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (release-6.4@a4208af). Click here to learn what that means.
The diff coverage is 70.37%.

@@              Coverage Diff               @@
##             release-6.4     #973   +/-   ##
==============================================
  Coverage               ?   56.67%           
==============================================
  Files                  ?      310           
  Lines                  ?    23961           
  Branches               ?        0           
==============================================
  Hits                   ?    13580           
  Misses                 ?    10381           
  Partials               ?        0
Impacted Files Coverage Δ
dart/utils/PackageResourceRetriever.hpp 100% <ø> (ø)
dart/common/ResourceRetriever.hpp 100% <ø> (ø)
dart/common/LocalResourceRetriever.hpp 100% <ø> (ø)
dart/utils/CompositeResourceRetriever.hpp 100% <ø> (ø)
dart/utils/DartResourceRetriever.hpp 100% <ø> (ø)
dart/common/ResourceRetriever.cpp 44.44% <0%> (ø)
dart/utils/PackageResourceRetriever.cpp 89.23% <100%> (ø)
dart/utils/CompositeResourceRetriever.cpp 85.71% <100%> (ø)
dart/dynamics/MeshShape.cpp 61.39% <44.44%> (ø)
dart/common/LocalResourceRetriever.cpp 90% <90%> (ø)
... and 1 more

@jslee02 jslee02 merged commit f1ea7fc into release-6.4 Feb 13, 2018
@jslee02 jslee02 deleted the 6.4/osg_texture_v2 branch February 13, 2018 04:34
@costashatz costashatz mentioned this pull request Feb 13, 2018
jslee02 added a commit that referenced this pull request Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant