-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test framework to Angular 10 (DSP-789) #213
Conversation
karma.conf.js:
http://karma-runner.github.io/5.0/config/configuration-file.html Now we have a situation where the library is built for production with the settings Line 11 in 65389df
but for the unit tests with Karma, this setting is used: Line 44 in 65389df
In short, the unit tests build (transpile) the JS code with different settings so it is unclear whether this could lead to bugs which cannot be detected. However, the E2E use the library with its productive build options. Karma: |
This reverts commit ddc0e20.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
resolves DSP-789
Update test framework from Angular 9 to 10.
TODO: resolve problems with libs built with CommonJS module:
TS config:
--module amd
microsoft/TypeScript#25755Angular 10: