Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to sipi base image with ffmpeg #358

Merged
merged 4 commits into from
Oct 6, 2021
Merged

build: update to sipi base image with ffmpeg #358

merged 4 commits into from
Oct 6, 2021

Conversation

subotic
Copy link
Contributor

@subotic subotic commented Sep 24, 2021 •
edited
Loading

@subotic subotic self-assigned this Sep 24, 2021
@irinaschubert irinaschubert self-requested a review October 4, 2021 07:52
@irinaschubert
Copy link

irinaschubert commented Oct 5, 2021 •
edited
Loading

@subotic I changed the expected mimetype of a CSV file in the failing test which was expecting plain/text but application/csv was the actual mimetype. I didn't understand how Lua (or Sipi) extracts the mimetype. For CSV text/csv would be better according to https://datatracker.ietf.org/doc/html/rfc4180. But application/csv is OK as well, I guess. Tests should run through now (they did locally).

@subotic
Copy link
Contributor Author

subotic commented Oct 5, 2021

great, thanks

@subotic subotic merged commit cf20c61 into main Oct 6, 2021
@subotic subotic deleted the wip/DEV-27-add-ffmpeg branch October 6, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irinaschubert irinaschubert irinaschubert approved these changes

Assignees

@subotic subotic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subotic @irinaschubert