Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to sipi base image with ffmpeg #358

Merged
merged 4 commits into from
Oct 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# STAGE 1: Build
FROM dhlabbasel/sipi-base:18.04 as builder
FROM daschswiss/sipi-base:2.4 as builder

WORKDIR /sipi

Expand All @@ -13,7 +13,7 @@ RUN mkdir -p /sipi/build-linux && \
make

# STAGE 2: Setup
FROM dhlabbasel/sipi-base:18.04
FROM daschswiss/sipi-base:2.4

MAINTAINER Ivan Subotic <400790+subotic@users.noreply.github.com>

Expand Down
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,21 @@ publish-sipi-image: build-sipi-image ## publish Sipi Docker image to Docker-Hub

.PHONY: compile
compile: ## compile SIPI inside Docker
docker run -it --rm -v ${PWD}:/sipi dhlabbasel/sipi-base:18.04 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make"
docker run -it --rm -v ${PWD}:/sipi daschswiss/sipi-base:2.4 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make"

.PHONY: compile-ci
compile-ci: ## compile SIPI inside Docker (no it)
docker run --rm -v ${PWD}:/sipi dhlabbasel/sipi-base:18.04 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make"
docker run --rm -v ${PWD}:/sipi daschswiss/sipi-base:2.4 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make"

.PHONY: test
test: ## compile and run tests inside Docker
@mkdir -p ${PWD}/images
docker run -it --rm -v ${PWD}:/sipi dhlabbasel/sipi-base:18.04 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make && ctest --verbose"
docker run -it --rm -v ${PWD}:/sipi daschswiss/sipi-base:2.4 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make && ctest --verbose"

.PHONY: test-ci
test-ci: ## compile and run tests inside Docker (no it)
@mkdir -p ${CURRENT_DIR}/images
docker run --rm -v ${PWD}:/sipi dhlabbasel/sipi-base:18.04 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make && ctest --verbose"
docker run --rm -v ${PWD}:/sipi daschswiss/sipi-base:2.4 /bin/sh -c "mkdir -p /sipi/build-linux && cd /sipi/build-linux && cmake .. && make && ctest --verbose"

.PHONY: test-integration
test-integration: build-sipi-image ## run tests against locally published Sipi Docker image
Expand Down
2 changes: 1 addition & 1 deletion test/_test_data/scripts/test_mimetype_func.lua
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ local test_files = {
},
{
filename = 'test.csv',
expected_mimetype = "text/plain"
expected_mimetype = "application/csv"
}
}

Expand Down