DlgPrefColors: use full palette preview for icons in comboboxes #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
commented
Mar 25, 2020
•
Be-ing
commented
Be-ing
force-pushed
the
color_preferences
branch
from
84a43ec to
5d4321f
Compare
Holzhaus
referenced
this pull request
in mixxxdj/mixxx
Mar 25, 2020
daschuer
requested changes
Mar 26, 2020
| <string>Hotcue default color</string> | ||
| </property> | ||
| </widget> | ||
| <widget class="QComboBox" name="comboBoxHotcueDefaultColor"/> |
There was a problem hiding this comment.
Please restore the expanding style.
This removes the gap between the labels an the box.
There was a problem hiding this comment.
I don't know what you mean. All I did was delete widgets in Qt Creator and save. I don't see a difference in the spacing compared to the screenshots in mixxxdj#2589 If there's something you think needs fixing here, could you take care of it?
|
Ready for merge? |
Be-ing
force-pushed
the
color_preferences
branch
from
85f1ce6 to
4176013
Compare
|
Thank you. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.