Skip to content

Commit

Permalink
Limit auto color asignment to 8
Browse files Browse the repository at this point in the history
  • Loading branch information
daschuer committed Mar 24, 2020
1 parent f9714bb commit 539d4da
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/util/color/colorpalette.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ mixxx::RgbColor ColorPalette::colorForHotcueIndex(unsigned int hotcueIndex) cons
int colorIndex;
if (m_hotcueColorIndices.isEmpty()) {
// For hotcue n, get nth color from palette
colorIndex = hotcueIndex;
// But use only 8 to avoid odd apearances on Hercules P32 or similar
colorIndex = hotcueIndex % 8;
} else {
// For hotcue n, get nth color from palette
colorIndex = m_hotcueColorIndices.at(hotcueIndex % m_hotcueColorIndices.size());
Expand Down

3 comments on commit 539d4da

@Holzhaus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this, why can't I auto assign more than 8 hotcue colors?

@daschuer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can. For my understanding this is only the default, before one starts to edit the palette.
In the GUI we have only 8 buttons anyway.

It was a originally request from Be where 9 colors are looking ugly on his Launchpad.

I personally don't mind at all.

@Be-ing: thoughts?

@Holzhaus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Be-ing reverted this in daschuer#50.

Please sign in to comment.