feat!: use new error codes and data for ABCI responses

lib/abci/errors/wrapInErrorHandlerFactory.js

@@ -1,15 +1,6 @@
-const {
-  tendermint: {
-    abci: {
-      Event,
-      EventAttribute,
-    },
-  },
-} = require('@dashevo/abci/types');
-
-const AbciError = require('./AbciError');
-const InternalAbciError = require('./InternalAbciError');
-const VerboseInternalAbciError = require('./VerboseInternalAbciError');
+const GrpcError = require('@dashevo/grpc-common/lib/server/error/GrpcError');
+const InternalGrpcError = require('@dashevo/grpc-common/lib/server/error/InternalGrpcError');
+const VerboseInternalGrpcError = require('@dashevo/grpc-common/lib/server/error/VerboseInternalGrpcError');
 
 /**
  * @param {BaseLogger} logger
@@ -46,12 +37,12 @@ function wrapInErrorHandlerFactory(logger, isProductionEnvironment) {
         let error = e;
 
         // Wrap all non ABCI errors to an internal ABCI error
-        if (!(e instanceof AbciError)) {
-          error = new InternalAbciError(e);
+        if (!(e instanceof GrpcError)) {
+          error = new InternalGrpcError(e);
         }
 
         // Log only internal ABCI errors
-        if (error instanceof InternalAbciError) {
+        if (error instanceof InternalGrpcError) {
           // in consensus ABCI handlers (blockBegin, deliverTx, blockEnd, commit)
           // we should propagate the error upwards
           // to halt the Drive
@@ -69,31 +60,18 @@ function wrapInErrorHandlerFactory(logger, isProductionEnvironment) {
           );
 
           if (!isProductionEnvironment) {
-            error = new VerboseInternalAbciError(error);
+            error = new VerboseInternalGrpcError(error);
           }
         }
 
-        const events = [];
-
-        const attributes = Object.entries(error.getTags())
-          .map(([key, value]) => new EventAttribute({ key, value, index: true }));
-
-        if (attributes.length > 0) {
-          events.push(new Event({
-            type: 'error',
-            attributes,
-          }));
-        }
-
         return {
           code: error.getCode(),
           log: JSON.stringify({
             error: {
               message: error.getMessage(),
-              data: error.getData(),
+              data: error.getRawMetadata(),
             },
           }),
-          events,
         };
       }
     }

lib/abci/handlers/deliverTxHandlerFactory.js

@@ -13,7 +13,7 @@ const AbstractDocumentTransition = require(
   '@dashevo/dpp/lib/document/stateTransition/DocumentsBatchTransition/documentTransition/AbstractDocumentTransition',
 );
 
-const InvalidArgumentAbciError = require('../errors/InvalidArgumentAbciError');
+const InvalidArgumentGrpcError = require('@dashevo/grpc-common/lib/server/error/InvalidArgumentGrpcError');
 
 const DOCUMENT_ACTION_DESCRIPTONS = {
   [AbstractDocumentTransition.ACTIONS.CREATE]: 'created',
@@ -87,7 +87,7 @@ function deliverTxHandlerFactory(
 
       blockExecutionContext.incrementInvalidTxCount();
 
-      throw new InvalidArgumentAbciError('Invalid state transition', { errors: result.getErrors() });
+      throw new InvalidArgumentGrpcError('Invalid state transition', { errors: result.getErrors() });
     }
 
     // Apply state transition to the state

lib/abci/handlers/query/dataContractQueryHandlerFactory.js

@@ -13,7 +13,7 @@ const {
   },
 } = require('@dashevo/dapi-grpc');
 
-const NotFoundAbciError = require('../../errors/NotFoundAbciError');
+const NotFoundGrpcError = require('@dashevo/grpc-common/lib/server/error/NotFoundGrpcError');
 
 /**
  *
@@ -44,7 +44,7 @@ function dataContractQueryHandlerFactory(
   async function dataContractQueryHandler(params, { id }, request) {
     // There is no signed state (current committed block height less then 2)
     if (blockExecutionContext.isEmpty() || previousBlockExecutionContext.isEmpty()) {
-      throw new NotFoundAbciError('Data Contract not found');
+      throw new NotFoundGrpcError('Data Contract not found');
     }
 
     const response = createQueryResponse(GetDataContractResponse, request.prove);
@@ -53,7 +53,7 @@ function dataContractQueryHandlerFactory(
 
     let dataContractBuffer;
     if (!dataContract && !request.prove) {
-      throw new NotFoundAbciError('Data Contract not found');
+      throw new NotFoundGrpcError('Data Contract not found');
     } else if (dataContract) {
       dataContractBuffer = dataContract.toBuffer();
     }

lib/abci/handlers/query/documentQueryHandlerFactory.js

@@ -14,9 +14,9 @@ const {
   },
 } = require('@dashevo/dapi-grpc');
 
+const InvalidArgumentGrpcError = require('@dashevo/grpc-common/lib/server/error/InvalidArgumentGrpcError');
+const UnavailableGrpcError = require('@dashevo/grpc-common/lib/server/error/UnavailableGrpcError');
 const InvalidQueryError = require('../../../document/errors/InvalidQueryError');
-const InvalidArgumentAbciError = require('../../errors/InvalidArgumentAbciError');
-const UnavailableAbciError = require('../../errors/UnavailableAbciError');
 
 /**
  *
@@ -77,13 +77,13 @@ function documentQueryHandlerFactory(
     }
 
     if (!container.has('previousBlockExecutionStoreTransactions')) {
-      throw new UnavailableAbciError();
+      throw new UnavailableGrpcError();
     }
 
     const previousBlockExecutionTransactions = container.resolve('previousBlockExecutionStoreTransactions');
     const dataContractTransaction = previousBlockExecutionTransactions.getTransaction('dataContracts');
     if (!dataContractTransaction.isStarted()) {
-      throw new UnavailableAbciError();
+      throw new UnavailableGrpcError();
     }
 
     const response = createQueryResponse(GetDocumentsResponse, request.prove);
@@ -100,7 +100,7 @@ function documentQueryHandlerFactory(
       });
     } catch (e) {
       if (e instanceof InvalidQueryError) {
-        throw new InvalidArgumentAbciError(
+        throw new InvalidArgumentGrpcError(
           `Invalid query: ${e.getErrors()[0].message}`,
           { errors: e.getErrors() },
         );

lib/abci/handlers/query/identitiesByPublicKeyHashesQueryHandlerFactory.js

@@ -14,7 +14,7 @@ const {
   },
 } = require('@dashevo/dapi-grpc');
 
-const InvalidArgumentAbciError = require('../../errors/InvalidArgumentAbciError');
+const InvalidArgumentGrpcError = require('@dashevo/grpc-common/lib/server/error/InvalidArgumentGrpcError');
 
 /**
  *
@@ -50,7 +50,7 @@ function identitiesByPublicKeyHashesQueryHandlerFactory(
    */
   async function identitiesByPublicKeyHashesQueryHandler(params, { publicKeyHashes }, request) {
     if (publicKeyHashes && publicKeyHashes.length > maxIdentitiesPerRequest) {
-      throw new InvalidArgumentAbciError(
+      throw new InvalidArgumentGrpcError(
         `Maximum number of ${maxIdentitiesPerRequest} requested items exceeded.`, {
           maxIdentitiesPerRequest,
         },

lib/abci/handlers/query/identityIdsByPublicKeyHashesQueryHandlerFactory.js

@@ -14,7 +14,7 @@ const {
   },
 } = require('@dashevo/dapi-grpc');
 
-const InvalidArgumentAbciError = require('../../errors/InvalidArgumentAbciError');
+const InvalidArgumentGrpcError = require('@dashevo/grpc-common/lib/server/error/InvalidArgumentGrpcError');
 
 /**
  *
@@ -46,7 +46,7 @@ function identityIdsByPublicKeyHashesQueryHandlerFactory(
    */
   async function identityIdsByPublicKeyHashesQueryHandler(params, { publicKeyHashes }, request) {
     if (publicKeyHashes && publicKeyHashes.length > maxIdentitiesPerRequest) {
-      throw new InvalidArgumentAbciError(
+      throw new InvalidArgumentGrpcError(
         `Maximum number of ${maxIdentitiesPerRequest} requested items exceeded.`, {
           maxIdentitiesPerRequest,
         },