Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat!: use new error codes and data for ABCI responses #562

Merged
merged 14 commits into from
Sep 15, 2021
Merged

feat!: use new error codes and data for ABCI responses #562

merged 14 commits into from
Sep 15, 2021

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Aug 26, 2021 •
edited by shumkov
Loading

Issue being fixed or feature implemented

To provide comprehensive error reporting, use existing common gRPC error statuses instead of handmade ABCI errors and pass DPP error codes to ABCI responses.

What was done?

  • Use gRPC error codes instead of handmade ABCI errors
  • Pass DPP validation errors to ABCI response
  • Use info instead of log to pass required error metadata.

How Has This Been Tested?

  • With CI

Breaking Changes

Drive responds with new error codes for transaction result

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov requested a review from shumkov August 26, 2021 11:03
@shuplenkov shuplenkov added this to the v0.21.0 milestone Aug 26, 2021
shumkov
shumkov previously approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

Konstantin Shuplenkov and others added 3 commits September 2, 2021 17:29
shumkov
shumkov previously approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Konstantin Shuplenkov added 2 commits September 8, 2021 15:28
@shumkov shumkov changed the title feat: use gRPC error codes for ABCI feat: use gRPC error codes for ABCI errors Sep 15, 2021
@shumkov shumkov mentioned this pull request Sep 15, 2021
Merged
5 tasks
@shumkov shumkov changed the title feat: use gRPC error codes for ABCI errors feat!: use new error codes and data for ABCI responses Sep 15, 2021
This was referenced Sep 15, 2021
Merged
Merged
shumkov
shumkov approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit bda325c into v0.21-dev Sep 15, 2021
@shumkov shumkov deleted the feat/grpc-error-codes branch November 2, 2021 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov