v0.6-dev to master

[ogabrielides]

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced functionality for scheduling votes, including a new screen for managing scheduled votes.
  • Added a new enum variant for tracking individual vote casting status.
  • Enhanced wallet management and error handling across various screens.

• UI Improvements

  • Updated titles and labels across multiple screens for clarity.
  • Improved user feedback mechanisms, including message expiration and error reporting.

• Bug Fixes

  • Refined error handling in wallet selection and identity management processes.

• Chores

  • Updated package version and dependencies to improve overall performance and stability.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces significant updates across various files, primarily focusing on enhancing the scheduled voting functionality within the application. Key changes include modifications to the Cargo.toml for versioning and dependency updates, as well as extensive updates to the application logic related to voting, including new methods for managing scheduled votes, improved error handling, and user interface enhancements. New enums and structs are introduced to track vote statuses and manage user interactions, ensuring a more robust voting experience.

Changes

File Path	Change Summary
Cargo.toml	Updated package version from 0.3.1 to 0.6.0 and revised dash-sdk dependency revision.
src/app.rs	Added logic for handling scheduled votes, including new fields and enum variants in AppState and AppAction.
src/backend_task/contested_names/mod.rs	Updated ContestedResourceTask enum to manage scheduled votes with new variants and modified handling methods.
src/backend_task/contested_names/vote_on_dpns_name.rs	Renamed parameter for visibility and added error handling for voting process.
src/backend_task/core/mod.rs	Enhanced error handling for CoreTask::RefreshWalletInfo.
src/backend_task/core/refresh_wallet_info.rs	Changed return value to provide success messages instead of None.
src/backend_task/identity/load_identity.rs	Updated wallet data handling to ensure consistent data structures.
src/backend_task/identity/mod.rs	Introduced new module and enum variant for refreshing DPNS names.
src/backend_task/identity/refresh_loaded_identities_dpns_names.rs	Added method for refreshing DPNS names associated with identities.
src/backend_task/identity/transfer.rs	Updated error messages for transfer operations.
src/backend_task/mod.rs	Added new variants to BackendTaskSuccessResult for scheduled votes.
src/context.rs	Changed wallets field type and added methods for managing scheduled votes.
src/database/identities.rs	Updated method parameter types for wallet handling.
src/database/initialization.rs	Updated DEFAULT_DB_VERSION to 5 and added logic for initializing scheduled votes table.
src/database/mod.rs	Introduced new module for scheduled votes.
src/database/scheduled_votes.rs	Added methods for managing scheduled votes in the database.
src/main.rs	Updated application title to include version from environment variables.
src/model/contested_name.rs	Added PartialEq trait to ContestState enum.
src/model/qualified_identity/mod.rs	Enhanced error handling and initialization in QualifiedIdentity.
src/model/qualified_identity/qualified_identity_public_key.rs	Updated method signature for wallet handling.
src/model/wallet/mod.rs	Added method to retrieve private keys based on derivation paths.
src/ui/components/dpns_subscreen_chooser_panel.rs	Added new subscreen option for scheduled votes.
src/ui/components/top_panel.rs	Modified UI layout for button spacing.
src/ui/components/wallet_unlock.rs	Enhanced user feedback for wallet unlock UI.
src/ui/document_query_screen.rs	Updated title in the UI.
src/ui/dpns_contested_names_screen.rs	Added support for scheduled votes, including new fields and rendering logic.
src/ui/dpns_vote_scheduling_screen.rs	Introduced UI for scheduling votes, including user input handling.
src/ui/identities/add_existing_identity_screen.rs	Updated wallet selection logic.
src/ui/identities/add_new_identity_screen/mod.rs	Refined wallet access logic.
src/ui/identities/identities_screen.rs	Modified alias management and wallet access logic.
src/ui/identities/keys/key_info_screen.rs	Enhanced wallet management and private key handling.
src/ui/identities/register_dpns_name_screen.rs	Streamlined identity selection and wallet retrieval processes.
src/ui/identities/top_up_identity_screen/mod.rs	Cleaned up unused fields and improved UI prompts.
src/ui/mod.rs	Added new modules and updated enums for scheduled votes.
src/ui/network_chooser_screen.rs	Updated context management for network selection.
src/ui/tool_screens/proof_log_screen.rs	Updated UI title in the proof log screen.
src/ui/tool_screens/transition_visualizer_screen.rs	Updated UI title for the transition visualizer.
src/ui/transfers/mod.rs	Enhanced transfer functionality with new status tracking and UI updates.
src/ui/wallet/add_new_wallet_screen.rs	Updated wallet storage logic and UI labels.
src/ui/wallet/import_wallet_screen.rs	Overhauled wallet import functionality with new fields and methods.
src/ui/wallet/wallets_screen/mod.rs	Improved message handling and wallet selection logic.
src/ui/withdrawal_statuses_screen.rs	Updated UI title and enhanced withdrawal data display handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App
    participant Backend
    participant Database

    User->>App: Request to schedule a vote
    App->>Backend: Send scheduled vote details
    Backend->>Database: Insert scheduled vote
    Database-->>Backend: Confirmation of insertion
    Backend-->>App: Success response
    App-->>User: Notify user of successful scheduling

Loading

Possibly related PRs

• fix: active contest vote tallies were not being updated with refresh button #6: Addresses handling of active contest vote tallies, related to scheduled voting functionality.
• feat: refresh identities #14: Introduces a refresh mechanism for identities, relevant to scheduled voting updates.
• feat: dpns subscreens #18: Enhances handling of DPNS subscreens, aligning with scheduled votes management.
• feat: withdrawals screen enhancements #20: Improves withdrawals screen, indicating ongoing enhancements in voting and financial management.
• feat: view more keys pop-up in identities screen #25: Introduces a pop-up for viewing more keys, complementing voting features.
• feat: database version handling #42: Focuses on database version handling, crucial for voting data integrity.
• fix: identities screen formatting #48: Addresses formatting issues in the identities screen, related to UI improvements.
• feat: retry vote poll end times query and insert proof logs #81: Introduces retry mechanisms for querying vote poll end times, relevant to scheduled voting.
• feat: deferred voting #129: Directly relates to the main PR by introducing deferred voting functionality.

Suggested reviewers

• QuantumExplorer
• pauldelucia

Poem

🐰 In the land of votes so bright,
A rabbit hops with pure delight.
With scheduled votes now in the fray,
We’ll cast our choices, come what may!
A hop, a skip, a vote to share,
In this new world, we show we care! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2565719 and 64c26dc.

📒 Files selected for processing (42)

• Cargo.toml (2 hunks)
• src/app.rs (15 hunks)
• src/backend_task/contested_names/mod.rs (2 hunks)
• src/backend_task/contested_names/vote_on_dpns_name.rs (2 hunks)
• src/backend_task/core/mod.rs (1 hunks)
• src/backend_task/core/refresh_wallet_info.rs (1 hunks)
• src/backend_task/identity/load_identity.rs (5 hunks)
• src/backend_task/identity/mod.rs (3 hunks)
• src/backend_task/identity/refresh_loaded_identities_dpns_names.rs (1 hunks)
• src/backend_task/identity/transfer.rs (1 hunks)
• src/backend_task/mod.rs (2 hunks)
• src/context.rs (10 hunks)
• src/database/identities.rs (3 hunks)
• src/database/initialization.rs (3 hunks)
• src/database/mod.rs (1 hunks)
• src/database/scheduled_votes.rs (1 hunks)
• src/main.rs (2 hunks)
• src/model/contested_name.rs (1 hunks)
• src/model/qualified_identity/mod.rs (1 hunks)
• src/model/qualified_identity/qualified_identity_public_key.rs (1 hunks)
• src/model/wallet/mod.rs (1 hunks)
• src/ui/components/dpns_subscreen_chooser_panel.rs (2 hunks)
• src/ui/components/top_panel.rs (1 hunks)
• src/ui/components/wallet_unlock.rs (1 hunks)
• src/ui/document_query_screen.rs (1 hunks)
• src/ui/dpns_contested_names_screen.rs (24 hunks)
• src/ui/dpns_vote_scheduling_screen.rs (1 hunks)
• src/ui/identities/add_existing_identity_screen.rs (3 hunks)
• src/ui/identities/add_new_identity_screen/mod.rs (3 hunks)
• src/ui/identities/identities_screen.rs (8 hunks)
• src/ui/identities/keys/key_info_screen.rs (5 hunks)
• src/ui/identities/register_dpns_name_screen.rs (6 hunks)
• src/ui/identities/top_up_identity_screen/mod.rs (5 hunks)
• src/ui/mod.rs (18 hunks)
• src/ui/network_chooser_screen.rs (1 hunks)
• src/ui/tool_screens/proof_log_screen.rs (1 hunks)
• src/ui/tool_screens/transition_visualizer_screen.rs (1 hunks)
• src/ui/transfers/mod.rs (9 hunks)
• src/ui/wallet/add_new_wallet_screen.rs (3 hunks)
• src/ui/wallet/import_wallet_screen.rs (3 hunks)
• src/ui/wallet/wallets_screen/mod.rs (9 hunks)
• src/ui/withdrawal_statuses_screen.rs (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.