feat: withdrawals screen enhancements

[ogabrielides]

Follow up of PR #17

This PR includes:

• Auto-query at startup
• Auto refresh when a filter is selected
• Handling case when no withdrawal is matching the selected filters
• Fetching data in batches

Summary by CodeRabbit

• New Features

  • Enhanced the Withdraws Status Screen with improved state management and user feedback during data loading.
  • Introduced a loading spinner to indicate data retrieval status.
  • Added pagination controls for better navigation of withdrawal data.

• Improvements

  • Updated methods to return actions, allowing for better handling of user interactions and data requests.
  • Improved messaging for scenarios with no withdrawal data.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request enhance the WithdrawsStatusScreen struct in src/ui/withdraws_status_screen.rs by adding new fields for managing loading states and data requests. The show_output and show_withdraws_data methods are modified to return AppAction, allowing for improved user interaction and state management. The pagination logic is refined, and new methods for loading indicators and message displays are introduced. These modifications collectively improve the functionality and responsiveness of the withdrawal status interface.

Changes

File	Change Summary
src/ui/withdraws_status_screen.rs	- Added fields first_load: Cell<bool>, requested_data: Cell<bool> to WithdrawsStatusScreen struct. - Updated show_output to return AppAction. - Updated show_withdraws_data to return AppAction and enhanced pagination logic. - Introduced load_spinner method and updated display_message and display_task_result methods to reset requested_data.

Poem

In the screen of withdraws, a new tale we weave,
With spinners and actions, oh, what we believe!
First loads are welcome, and data's a breeze,
Pagination's a dance, done with grace and ease.
So hop on, dear user, enjoy the new flow,
For the rabbit's here, making changes that glow! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ogabrielides]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (3)

src/ui/withdraws_status_screen.rs (3)

20-21: Add documentation for new struct fields

Consider adding documentation comments for the new fields first_load and requested_data in the WithdrawsStatusScreen struct to enhance code readability and maintainability.

---

258-258: Remove unnecessary parentheses in if condition

In Rust, parentheses around if conditions are not required and typically omitted for clarity.

Apply this change:

-if (total_pages > 0) {
+if total_pages > 0 {

---

333-334: Consistent else formatting

Place the else keyword on the same line as the closing brace of the preceding if block to maintain consistent coding style.

Apply this change:

-}
-else {
+} else {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1c720c2 and 8f69efa.

📒 Files selected for processing (1)

• src/ui/withdraws_status_screen.rs (10 hunks)

🔇 Additional comments (1)

src/ui/withdraws_status_screen.rs (1)

410-410: Ensure requested_data flag is consistently managed

The requested_data flag is set to false in both display_message and display_task_result methods. Ensure this flag is correctly managed in all code paths to prevent inconsistent loading states.

Also applies to: 420-420

[ogabrielides]

https://github.com/coderabbitai review