fix: collaterals being spent when creating protx #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strophy
added a commit
that referenced
this pull request
Dec 16, 2022
5 tasks
strophy
added a commit
that referenced
this pull request
Dec 16, 2022
* chore: revert #400 and move fee function to mn_init * chore: handle misconfigured masternodes (enabled but wrong ip) * chore: avoid using broken `loadwallet` locking function * docs: add sections to mn_init for clarity * fix: trailing spaces
strophy
added a commit
that referenced
this pull request
Dec 19, 2022
* chore: revert #400 and move fee function to mn_init * chore: handle misconfigured masternodes (enabled but wrong ip) * chore: avoid using broken `loadwallet` locking function * docs: add sections to mn_init for clarity * fix: trailing spaces
strophy
added a commit
that referenced
this pull request
Mar 5, 2023
* chore: add uacomment to dash.conf (#407) * chore: fix loadwallet and handle misconfigured masternodes (#408) * chore: revert #400 and move fee function to mn_init * chore: handle misconfigured masternodes (enabled but wrong ip) * chore: avoid using broken `loadwallet` locking function * docs: add sections to mn_init for clarity * fix: trailing spaces * fix: uacomment spacing (#413) * fix: miner-2 smoke test timeout (#415) * chore: bump version to 0.23.1 (#416) * feat: use new recaptcha methods available in multifaucet 0.9.0 (#429) * feat: add tls to faucet (#430) * feat: enable SPORK_23_QUORUM_POSE * fix: logrotate hourly fails if drive fills before dateext changes * chore: revert enabling spork 23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Collaterals are consumed as fees when creating protx transactions using a named wallet in Core 18
What was done?
Work around the issue by funding a separate fee address
How Has This Been Tested?
Currently testing on
devnet-feefixBreaking Changes
Checklist:
For repository code-owners and collaborators only