Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add uacomment to dash.conf #407

Merged
merged 1 commit into from
Dec 10, 2022
Merged

chore: add uacomment to dash.conf #407

merged 1 commit into from
Dec 10, 2022

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Dec 10, 2022

Issue being fixed or feature implemented

Adding a uacomment can help devs and external users identify which servers they are connected to, which is useful for debugging.

What was done?

Add uacomment to dash.conf

How Has This Been Tested?

On testnet masternode-111:

root@masternode-111:/dash/dashcore# dash-cli getnetworkinfo
{
  "version": 180200,
  "buildversion": "v18.2.0-rc.2",
  "subversion": "/Dash Core:18.2.0(dcg-masternode-111)/",
  "protocolversion": 70224,
  ...

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.23.x milestone Dec 10, 2022
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems conceptually fine to me.

@strophy strophy merged commit ca59ff2 into master Dec 10, 2022
@strophy strophy deleted the chore/add-uacomment branch December 10, 2022 23:27
ktechmidas pushed a commit that referenced this pull request Feb 11, 2023
ktechmidas pushed a commit that referenced this pull request Feb 11, 2023
strophy added a commit that referenced this pull request Mar 5, 2023
* chore: add uacomment to dash.conf (#407)

* chore: fix loadwallet and handle misconfigured masternodes (#408)

* chore: revert #400 and move fee function to mn_init

* chore: handle misconfigured masternodes (enabled but wrong ip)

* chore: avoid using broken `loadwallet` locking function

* docs: add sections to mn_init for clarity

* fix: trailing spaces

* fix: uacomment spacing (#413)

* fix: miner-2 smoke test timeout (#415)

* chore: bump version to 0.23.1 (#416)

* feat: use new recaptcha methods available in multifaucet 0.9.0 (#429)

* feat: add tls to faucet (#430)

* feat: enable SPORK_23_QUORUM_POSE

* fix: logrotate hourly fails if drive fills before dateext changes

* chore: revert enabling spork 23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants