Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use reduced genesis.json template for tenderdash 0.10.0-dev.6+ #409

Merged
merged 1 commit into from
Dec 17, 2022
Merged

refactor: use reduced genesis.json template for tenderdash 0.10.0-dev.6+ #409

merged 1 commit into from
Dec 17, 2022

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Dec 17, 2022

Issue being fixed or feature implemented

Supersedes #368
genesis.json can be reduced as much of the config is supplied by drive

What was done?

remove/rename fields as necessary

How Has This Been Tested?

On devnet-bintang

Breaking Changes

Doesn't work with tenderdash < 0.10.0-dev.6

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.24.0 milestone Dec 17, 2022
@strophy strophy mentioned this pull request Dec 17, 2022
Closed
5 tasks
shumkov
shumkov approved these changes Dec 17, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title chore: use reduced genesis.json template for tenderdash 0.10.0-dev.6+ refactor: use reduced genesis.json template for tenderdash 0.10.0-dev.6+ Dec 17, 2022
@strophy strophy merged commit b6fe5e4 into v0.24-dev Dec 17, 2022
@strophy strophy deleted the reduce-genesis branch December 29, 2022 02:06
ktechmidas pushed a commit that referenced this pull request Feb 11, 2023
@strophy
chore: use reduced genesis.json template for tenderdash 0.10.0-dev.6+ (…
4438508 
…#409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@shuplenkov shuplenkov Awaiting requested review from shuplenkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@strophy @shumkov