chore: simplify genesis.json #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
reviewed
Oct 18, 2022
| @@ -1,43 +1,3 @@ | |||
| { | |||
| "genesis_time": "{{ genesis_time }}", | |||
| "chain_id": "dash-{{ ( 'devnet-' + dash_devnet_name if dash_network == 'devnet' else dash_network ) if tenderdash_chain_id is not defined else tenderdash_chain_id }}", | |||
| "initial_height": "0", | |||
There was a problem hiding this comment.
I would keep genesis_time, initial_height, initial_core_chain_locked_height, consensus_params, and quorum_type to make it more verbose and reduce future confusions.
@lklimek shall we rename:
threshold_public_key->validator_quorum_threshold_public_keyquorum_type->validator_quorum_typequorum_hash->validator_quorum_hash
There was a problem hiding this comment.
Fields renamed in PR dashpay/tenderdash#515 , started image build with tag rename-genesis-fields
5 tasks
|
Closed in favour of #409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Some fields are no longer necessary in
genesis.jsonWhat was done?
Delete fields
How Has This Been Tested?
On special devnet
Breaking Changes
Checklist:
For repository code-owners and collaborators only