Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types)!: rename genesis.json quorum fields #515

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Dec 5, 2022

Issue being fixed or feature implemented

To improve genesis JSON file and make it easier to understand, we rename some fields in genesis.json:

  1. threshold_public_key -> validator_quorum_threshold_public_key
  2. quorum_type -> validator_quorum_type
  3. quorum_hash -> validator_quorum_hash

What was done?

  1. Renamed fields
  2. Old field names are marked as "deprecated" and error is returned when one of them is present.

How Has This Been Tested?

Github pipelines

Breaking Changes

Fields renamed:

  • threshold_public_key -> validator_quorum_threshold_public_key
  • quorum_type -> validator_quorum_type
  • quorum_hash -> validator_quorum_hash

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek force-pushed the rename-genesis-fields branch 2 times, most recently from 94b7766 to 162b3cc Compare December 5, 2022 10:25
Copy link
Collaborator

@shotonoff shotonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
left a question about backward compatibility for old fields, not sure we have to care its at this moment

types/genesis.go Show resolved Hide resolved
@lklimek lklimek merged commit f62d7be into v0.10-dev Dec 13, 2022
@lklimek lklimek deleted the rename-genesis-fields branch December 13, 2022 15:28
shotonoff added a commit that referenced this pull request Dec 15, 2022
* chore(types)!: rename genesis.json quorum fields (#515)

* fix(consensus): ProcessProposal executed twice for a block (#516)

* fix(consensus): ProcessProposal executed twice for a block

* fix(consensus): ensure process proposal is called once before finalize block

* fix(consensus): ensure ProcessProposal is called at least once for a block

* build(deps): Bump actions/setup-go from 3.3.1 to 3.4.0 (#524)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): Bump bufbuild/buf-setup-action from 1.9.0 to 1.10.0 (#525)

Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.9.0...v1.10.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(consensus): proposer-based timestamp broken during backport (#523)

* fix(consensus): proposer-based timestamp is broken

* fix(consensus): initial block time  must be equal genesis time

* test(consensus): update TestStateProposalTime for PBTS

* test(consensus): fix TestStateLock_POLSafety2 for PBTS

* Revert "test(consensus): skip broken PBTS tests (#500)"

This reverts commit 02452f1.

* refactor(time): simplify time processing

* feat(log): Allow definition of log assertions in TestingLogger

* test(consensus): refactor PBTS tests

* chore(log): replace TestingLogger interface with struct

* chore(state): move block time logic to separate fn

* chore(abci)!: remove Snapshot.core_chain_locked_height (#527)

* chore(abci)!: remove Snapshot.core_chain_locked_height

* build: bump Golang to 1.19

* fix(wal): improve wal replay mechanism (#510)

* refactor: improve wal iterator

* feat: add config parameter to turn on/off skipping the WAL rounds to the last

* refactor: clean up code

* refactor: add TestWALRoundsSkipper

* fix: derive a commit from vote-set during replay

* fix: add validators priority incrementing to select proper proposer

* chore(release): update changelog and version to 0.10.0-dev.6 (#526)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants