Backport Bitcoin Qt/Gui changes up to 0.14.x part 2

[codablock]

This is the next batch of backported Qt/Gui related PRs. See #1614 for the first batch.

The PRs included in this batch should all work fine on their own, so if you feel one of them is too critical I can simply remove it.

The most critical here is probably bitcoin#8463, which removes the priority column from coin control. In the Bitcoin community this seemed to be mostly unused so they decided to remove it. I'd assume this is also true for Dash.

bitcoin#8371 adds the progress overlay (which was the initial reason to do all the backporting). With this batch of PRs the overlay misses some of the improvements made in later commits (which will be in the next batch). The most important ones are 2 commits that allow to bring up the overlay by clicking on the spinning icon or the progress label. If time runs out (due to feature freeze), I can limit the next batch to only include the overlay improvements.

EDIT: Just realized I used the wrong link for the modal overlay PR. Fixed the description.

[UdjinM6]

That's a lot of changes...

1. I'm by no means GUI guy :) but warning icon looks a bit ugly on modal overlay imo, could be made a bit prettier by adding css like that

diff --git a/src/qt/res/css/light.css b/src/qt/res/css/light.css
index ff9d3f862..560f5448e 100644
--- a/src/qt/res/css/light.css
+++ b/src/qt/res/css/light.css
@@ -1142,6 +1142,15 @@ margin-top:12px;
 margin-left:0px; /* CSS Voodoo - set to -66px to hide default transaction icons */
 }
 
+/* MODAL OVERLAY */
+
+QWidget#bgWidget .QPushButton#warningIcon {
+width:64px;
+height:64px;
+padding:5px;
+background-color:transparent;
+}
+
 /* SEND DIALOG */
 
 QDialog#SendCoinsDialog .QFrame#frameCoinControl { /* Coin Control Section */

to every .css or via adding similar styleSheet in modaloverlay.ui instead.

2. see connect issues in inline comments

3. modal overlay doesn't go away when blockchain sync is finished (unlike in bitcoin core) - is it smth that is kept for part3+ or are we missing some older PR here?

[UdjinM6]

Two labels above are QLabels in Dash and are not clickable, corresponding connects should be removed.

diff --git a/src/qt/overviewpage.cpp b/src/qt/overviewpage.cpp
index dd6bd6b27..08472a17c 100644
--- a/src/qt/overviewpage.cpp
+++ b/src/qt/overviewpage.cpp
@@ -157,9 +157,6 @@ OverviewPage::OverviewPage(const PlatformStyle *platformStyle, QWidget *parent)
 
     // start with displaying the "out of sync" warnings
     showOutOfSyncWarning(true);
-    connect(ui->labelWalletStatus, SIGNAL(clicked()), this, SLOT(handleOutOfSyncWarningClicks()));
-    connect(ui->labelTransactionsStatus, SIGNAL(clicked()), this, SLOT(handleOutOfSyncWarningClicks()));
-
 
     // that's it for litemode
     if(fLiteMode) return;

Some other related connects on overview screen are also useless due to this fact I guess, at least until this

The most important ones are 2 commits that allow to bring up the overlay by clicking on the spinning icon or the progress label.

is implemented.

[codablock]

I tried to figure out what happened here. It looks like in bitcoin these are actually buttons. This change was reverted while merging in 0.12 changes. The PR is #698, the commit is ad5da28
Do you remember why you had to revert those?

[UdjinM6]

Yep, we didn't want that warning icon all over the place back then and I doubt we want to change this now too. IMO clicking on the spinning icon or the progress bar/label would make more sense (I would maybe even go with spinning icon only).

[codablock]

You say "change this now too". Do you mean not change it forever or just not now? In case you want to change it someday in the future, I'd suggest to stick with the connect calls as they will then come in handy at that time.

I really like the clicking on the progress bar. When I've first seen the overlay in bitcoin and clicked on hide, it was kind of intuitional that I had to click on the progress bar to get it back. At that time I didn't even notice the small spinning icon on the bottom right. Also, the overlay moves smoothly to the bottom, so it's kind of clear that you have to bring it back up by clicking somewhere near where it vanished.

[UdjinM6]

I mean "nothing changed, should be no icons here". Can't predict the future ;) but if we ever would think about changing this to buttons for some reason I think we will add required connects at that time. Currently they are just spawning errors in debug.log (and make no sense).

[codablock]

1. I added a commit on top, thanks for the CSS snippets. I tried to figure out why this was not a problem in bitcoin, looks like it's because it's a button which in bitcoin has the same background color as the panel, while in Dash the buttons background is blue.
2. See answer on inline comment
3. Sorry, didn't realize it behaved different in bitcoin. Gonna check if the upcoming PRs would fix this, if not I'll look into a fix.

[codablock]

The next batch of PRs includes one change where I'm not sure what to do. There is this small connection status icon on the bottom right. In Dash, it was changed to open the peers list when clicking on it, while in bitcoin they changed it to toggle network status (disconnect all peers, go full offline). I'm not sure which feature you see as more valuable. IMHO, clicking on a status icon causing disconnection from the network is kind of awkward, so I'd prefer to stay with the Dash version of behavior.

[UdjinM6]

IMHO, clicking on a status icon causing disconnection from the network is kind of awkward

Agree. Though an easy way to quickly disconnect from the network might be a good idea... We could maybe replace instant click-to-action with a context menu for that icon (similar to the way units are selected) with two options:

• Peers list
• Go offline/online (could adjust the label text according to current state)

[codablock]

Just added 2 commits on top. The first one removes the connect calls and the second one makes the overlay disappear when the blockchain catches up. I had to fall back to the old style time based check from Bitcoin as otherwise the overlay would always appear on startup even though we are pretty close to being synced.

[UdjinM6]

tested, works as expected

ACK