Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge bitcoin/0.12 + few fixes #698

Merged
merged 2,378 commits into from
Feb 22, 2016
Merged

Merge bitcoin/0.12 + few fixes #698

merged 2,378 commits into from
Feb 22, 2016

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 21, 2016

“why?” https://github.com/bitcoin/bitcoin/blob/0.12/doc/release-notes.md#notable-changes

What's inside:

  • Merge all commits from remote-tracking branch 'bitcoin/0.12' and refactor code to match new structures/functions/arguments
  • Refactor keepass to use evhttp (need testing)
  • Move most hardcoded mainnet/testnet magic numbers to consensus part of chainparams, get rid of most if(Params().NetworkIDString() == CBaseChainParams::MAIN) and alike to unify formulas. Further improvements will require testnet restart (see TODO notes in changed code) so I'm keeping few things as they are till then.
  • There is no more AcceptableInputs, AcceptToMemoryPool/AcceptToMemoryPoolWorker have fDryRun parameter instead
  • Fix consensus.nSubsidyHalvingInterval (210000 -> 210240)
  • Replace hardcoded 9999 with Params(CBaseChainParams::MAIN).GetDefaultPort()
  • Replace all hardcoded network message strings with NetMsgType:: constants, log unknown commands (net debug category only)
  • UI fixes:
    • Refactor tools menu signals/slots, add more keyboard shortcuts
    • Refactor sync progress to use signals, remove lock from masternode count label updates
    • Fix icons in tx list to preserve our ui styles, fix about/cmd-line help dialog
    • Get rid of the new warning icon and use old text label instead
    • Update overview screen ds rounds/amount/progress when settings changed (we were already sending signals but connectors in overview screen were missing)
  • Quick fix for testnet - we reeeeally should restart it one day, it’s broken (see UdjinM6@29b1af2 and TODO in UdjinM6@e8d9aab)
  • Add note about GetBlockSubsidy using previous height, changed var names accordingly
  • Add few more debug messages for masternode category
  • Move historical bitcoin release notes to appropriate subfolder

Few notes/todos:

  • RBF is set to false by default (shall we remove RBF completely?)
  • I can’t compile on linux without --disable-hardening yet, it complains about x11 crypto (but as a side effect of --disable-hardening (?) - ubuntu recognize dash-qt as an executable again so maybe we should consider this as a default option?)
  • new keepass integration code need to be tested
  • gitian build is probably broken too, haven’t tested yet
  • release notes should be updated

MarcoFalke and others added 30 commits November 30, 2015 16:34
This allows us to optimize CTxMemPool::removeForReorg.
d52fbf0 Added additional config option for multiple RPC users. (Gregory Sanders)
Make RPC tests have a default block priority size of 50000 (the old default) so we can still use free transactions in RPC tests.  When priority is eliminated, we will have to make a different change if we want to continue allowing free txs.
996d311 [RPC] Add transaction size to JSON output (Nick)
ebb25f4 Limit setAskFor and retire requested entries only when a getdata returns. (Gregory Maxwell)
5029698 prevent peer flooding request queue for an inv (kazcw)
9ac63d6 Keep track of explicit wallet conflicts instead of using mempool (Pieter Wuille)
fa3a38a [qa] pull-tester: Cleanup (run keypool, tidy stdout) (MarcoFalke)
ff723da [Qt] improve minimum absolute fee option - Only display the minimum absolute fee control if CoinControl is enabled (Jonas Schnelli)
31b508a [Qt] make use of the nMinimumTotalFee (absolute) in coincontrols fee calculation (Jonas Schnelli)
80462dd [Qt] use ASYMP_UTF8 (≈) whenever we show a fee that is not absolute (Jonas Schnelli)
ecc7c82 Move fPayAtLeastCustomFee function to CC (Pieter Wuille)
But keep translating them in the GUI.
This - necessarily - requires duplication of a few messages.
Alternative take on bitcoin#7134, that keeps the translations from being wiped.

Also document GetWarnings() input argument.

Fixes #5895.
114b581 Prevector type (Pieter Wuille)
fa19a58 HelpMessage: Don't hide -mintxfee behind showDebug (MarcoFalke)
faffc17 rpcwallet: Clarify what settxfee does (MarcoFalke)
9999cb0 Fix url in .travis.yml (MarcoFalke)
fa22a10 contrib: Del. gitian downloader config and update gitian README (MarcoFalke)
fad3035 [doc] Minor markdown fixes (MarcoFalke)
2b31ab9 Add rpc test for prioritisetransaction (Suhas Daftuar)
6e8b07f Add rounding helper function to util.py (Suhas Daftuar)
…tmodel

It's surprising to me that Q_EMIT even worked for this.

But it doesn't build in Qt4, so switch back to
`QMetaObject::invokeMethod`. Fixes bitcoin#7138.
50947ef Change default block priority size to 0 (Alex Morcos)
2d8860e Fix removeForReorg to use MedianTimePast (Suhas Daftuar)
b7fa4aa Don't call removeForReorg if DisconnectTip fails (Suhas Daftuar)
7e49f5f Track coinbase spends in CTxMemPoolEntry (Suhas Daftuar)
bb8ea1f removeForReorg calls once-per-disconnect-> once-per-reorg (Matt Corallo)
474b84a Make indentation in ActivateBestChainStep readable (Matt Corallo)
b0a064c Fix comment in removeForReorg (Matt Corallo)
9b060e5 Fix removal of time-locked transactions during reorg (Matt Corallo)
0c9959a Add failing test checking timelocked-txn removal during reorg (Matt Corallo)
UdjinM6 and others added 18 commits February 15, 2016 22:02
The list of contributors is automatically generated from git, so people
that use multiple author names will end up on the list multiple times.
ea52530 Fix duplicate names in release notes (fanquake)
…f chainparams,

get rid of most `if(Params().NetworkIDString() == CBaseChainParams::MAIN)` and alike to unify formulas.
Further improvements will require testnet restart (see TODO notes in changed code) so I'm keeping few things as they are till then.
…ants, log unknown commands (net debug category only)
@UdjinM6 UdjinM6 added this to the 12.1 milestone Feb 21, 2016
@schinzelh
Copy link

Many thanks, I'll do some local build tests first to see if gitian/travis broke.

@eduffield222
Copy link

Yay, thanks!

eduffield222 pushed a commit that referenced this pull request Feb 22, 2016
Merge bitcoin/0.12 + few fixes
@eduffield222 eduffield222 merged commit e161616 into dashpay:v0.12.1.x Feb 22, 2016
@schinzelh
Copy link

@UdjinM6 i have fixed the issue with --disable-hardening: x11 crypto was compiled without fPIC support, which made Dash client linking fail.

I've commited the fix to 12.1 branch - can you retest on your side as well?

@UdjinM6
Copy link
Author

UdjinM6 commented Feb 23, 2016

@schinzelh Bingo! 👍

@schinzelh
Copy link

Gitian/Bamboo almost working again, only Windows build has i minor issue

/usr/bin/x86_64-w64-mingw32-windres -DWINDRES_PREPROC -i qt/res/dash-qt-res.rc -o qt/res/dash-qt-res.o /usr/bin/x86_64-w64-mingw32-windres: can't open icon fileicons/bitcoin.ico': No such file or directory
/usr/bin/x86_64-w64-mingw32-windres: preprocessing failed.
make[2]: *** [qt/res/dash-qt-res.o] Error 1
make[2]: Leaving directory /home/travis/build/dashpay/dash/dash-x86_64-w64-mingw32/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory/home/travis/build/dashpay/dash/dash-x86_64-w64-mingw32/src'
make: *** [all-recursive] Error 1
`

@thelazier
Copy link

Hope #700 help solving minor issue.

@schinzelh
Copy link

@thelazier thanks, that solved it, gitian builds working now again.

Travis is still failing due to some broken unittests, needs some more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.