Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jan 5, 2018

Such connections have short life (~1 min) and it turns out that they can be terminated at exactly the same moment we are trying to push a message here which can lead to a crash. It's better to avoid them completely and create a fresh new connection to another masternode instead of reusing them.

@UdjinM6 UdjinM6 modified the milestones: 12.3, 12.2.3 Jan 5, 2018
@UdjinM6 UdjinM6 mentioned this pull request Jan 5, 2018
9 tasks
Copy link

@schinzelh schinzelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gladcow
Copy link

gladcow commented Jan 8, 2018

utACK

@UdjinM6 UdjinM6 merged commit d69ad9d into dashpay:develop Jan 9, 2018
UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Jan 9, 2018
NarubyRiverlione added a commit to NarubyRiverlione/spice that referenced this pull request Feb 4, 2018
* 'spice' of github.com:NarubyRiverlione/spice: (8382 commits)
  updated testnet genessis
  spice images
  more rename
  genesis blocks ports magic message letters start letter addresses
  cleanup : * remove gitian signatures * remove seeds
  rename: more originale files
  rename
  Prepare 0.12.2.3 release notes (dashpay#1846)
  Avoid reference leakage in CKeyHolderStorage::AddKey (dashpay#1840)
  Protect CKeyHolderStorage via mutex (dashpay#1834)
  Skip existing masternode conections on mixing (dashpay#1833)
  Merge pull request dashpay#1836 from lodgepole/feature/backport-11847
  Fix -liquidityprovider option (dashpay#1829)
  Vote on IS only if it was accepted to mempool (dashpay#1826)
  bump version to 0.12.2.3 (dashpay#1827)
  Merge bitcoin#8256: BUG: bitcoin-qt crash
  Swap iterations and fUseInstantSend parameters in ApproximateBestSubset (dashpay#1819)
  Fix crash on exit when -createwalletbackups=0 (dashpay#1810)
  Prepare v0.12.2.2 release notes (dashpay#1769)
  Force rcc to use resource format version 1. (dashpay#1784)
  ...

# Conflicts:
#	contrib/gitian-descriptors/gitian-osx-signer.yml
#	contrib/gitian-descriptors/gitian-win-signer.yml
#	src/chainparams.cpp
#	src/qt/res/icons/bitcoin.icns
#	src/qt/res/icons/bitcoin.ico
#	src/qt/res/icons/bitcoin.png
#	src/qt/res/icons/crownium/about.png
#	src/qt/res/icons/drkblue/about.png
#	src/qt/res/icons/drkblue/bitcoin.png
#	src/qt/res/icons/light/about.png
#	src/qt/res/icons/light/remove.png
#	src/qt/res/icons/remove.png
#	src/qt/res/icons/trad/about.png
#	src/qt/res/icons/trad/remove.png
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Dec 26, 2018
@UdjinM6 UdjinM6 deleted the skipexistingmnsonmixing branch November 26, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants