remove boost dependency from Dash-specific code #2072
Conversation
|
Not sure if it's a good idea to touch message signing parts while we are in feature-freeze mode and since this fixes no bug I'd postpone this till 12.4. |
|
I absolutely agree w/you there, my intent was to just get it out for later. I can remember to make a note for PRs that I don't intend to be in the next release, esp. for cases like this where it's in freeze mode. |
Specifically for spork.cpp : this should be temporary until all spork sigs are based on hash and not string serialization format, after which I expect the old signatures (else branch) should go away altogether. But I still think it's worth it to get pieces of the boost dependency removed, and this is an easy win, and could be merged now or in a patch release w/o issue.
|
Rebased this onto latest |
|
@nmarley what is the point of removing it from dash-specific code if boost is still needed to compile, due to not changing boost depends from btc? |
|
@paulied So that we can drop it when it's time. It's a big ugly dependency that's largely been superceded with the new C++11/14/17 standards. Are you aware that Bitcoin is also migrating off Boost? : https://github.com/bitcoin/bitcoin/projects/3 |
|
No I did not see bitcoin was migrating away. This makes a fair bit more sense then. Thanks |
This is only a partial replacement, as some of the boost items aren't simple swaps. This PR replaces
lexical_castand the boost dependency in CSuperblockshared_ptr. The latter should be straightforward, doesn't use anything specific aboutboost::shared_ptrthat can't be done withstd::shared_ptr