forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string_cast benchmark #2073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @UdjinM6 , why not use the stringstream library for conversion from number to string? eg this function.
|
Added suggested test. New results:
|
ACK, my results (gcc 7.3.0, Ubuntu 18):
|
ACK, results on my machine:
|
nmarley
approved these changes
May 19, 2018
Yoyae
pushed a commit
to monacocoin-net/monoeci-core
that referenced
this pull request
May 28, 2018
* Add string_cast benchmark * add NumberToString
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
* Add string_cast benchmark * add NumberToString
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Mar 1, 2019
* Add string_cast benchmark * add NumberToString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark various ways of dealing with
int->string
/string->int
conversion.Example output:
atoi
andto_string
(including concatenation of multiple items) seems to be the fastest option on my machine.Somewhat complementary to #2072