Skip to content

Conversation

@UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Aug 28, 2019

Yet another attempt to fix #2423 , see discussion there.

Before:
Screenshot 2019-08-29 at 01 51 50
Screenshot 2019-08-29 at 01 52 07

After:
Screenshot 2019-08-29 at 01 53 14
Screenshot 2019-08-29 at 01 53 31

Example apps were built via make deploy but I guess gitian should produce correct numbers too.

A bit controversial thing about this is that Apple says it should be 3 digits, see CFBundleVersion and CFBundleShortVersionString docs but I hope it only applies to apps submitted to App Store.

@UdjinM6 UdjinM6 changed the title Use 4-digit version numbers for macOS bundles Update/modernize macOS plist Aug 30, 2019
@UdjinM6
Copy link
Author

UdjinM6 commented Aug 30, 2019

Added another commit on top. That's how it looks now:
Screenshot 2019-08-30 at 13 27 45
Screenshot 2019-08-30 at 13 27 57

Copy link

@codablock codablock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 77b8855 into dashpay:develop Sep 3, 2019
codablock pushed a commit to codablock/dash that referenced this pull request Nov 18, 2019
* Use 4-digit version numbers for macOS bundles

* Drop deprecated CFBundleGetInfoString and use NSHumanReadableCopyright instead
MIPPL pushed a commit to biblepay/biblepay that referenced this pull request Nov 24, 2019
* commit '8b14adb206d76fbc6307385999a1c512052e93fa': (21 commits)
  [v0.14.0.x] Update release notes with change log (dashpay#3213)
  [v0.14.0.x] Bump version to 0.14.0.4 and draft release notes (dashpay#3203)
  Circumvent BIP69 sorting in fundrawtransaction.py test (dashpay#3100)
  Fix compile issues
  Merge bitcoin#11397: net: Improve and document SOCKS code
  Slightly optimize ApproximateBestSubset and its usage for PS txes (dashpay#3184)
  Update activemn if protx info changed (dashpay#3176)
  Actually update spent index on DisconnectBlock (dashpay#3167)
  Only track last seen time instead of first and last seen time (dashpay#3165)
  Merge bitcoin#17118: build: depends macOS: point --sysroot to SDK (dashpay#3161)
  Simulate BlockConnected/BlockDisconnected for PS caches
  Few fixes related to SelectCoinsGroupedByAddresses (dashpay#3144)
  Various fixes for mixing queues (dashpay#3138)
  Also consider txindex for transactions in AlreadyHave() (dashpay#3126)
  Ignore recent rejects filter for locked txes (dashpay#3124)
  Make orphan TX map limiting dependent on total TX size instead of TX count (dashpay#3121)
  Update/modernize macOS plist (dashpay#3074)
  Fix bip69 vs change position issue (dashpay#3063)
  Partially revert 3061 (dashpay#3150)
  Fix SelectCoinsMinConf to allow instant respends (dashpay#3061)
  ...

# Conflicts:
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/wallet/wallet.cpp
@UdjinM6 UdjinM6 deleted the fix2423_second_attempt branch November 26, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants