Update activemn if protx info changed #3176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! 👍 However, it doesn't feel right to go through the init process again when say voting address has changed because voting address has nothing to do with the state of a MN. The only (not yet covered) case when you'd want to do this would be IP address changes imo. On the other hand, |
nmarley
force-pushed
the
activemn-update
branch
from
a695509 to
4120ca4
Compare
Author
|
👍 I like this better, originally tried doing something similar adding a comparison method to I have reset HEAD of this branch to your latest commit & force pushed. |
|
IMHO the correct solution would be to remove |
|
Agree, 3e0ff6e looks even better 👍 |
This reverts commit fba4687.
Author
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Nov 19, 2019
* Update activemn if protx info changed * Add `==` and `!=` operators to CDeterministicMNState * Only re-init active MN if its IP changed, changes to payout, voting etc. can be done without it * Test `masternode status` updates * Don't track mnListEntry anymore and instead get the DMN on demand * Revert "Add `==` and `!=` operators to CDeterministicMNState" This reverts commit fba4687.
MIPPL
pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 24, 2019
* commit '8b14adb206d76fbc6307385999a1c512052e93fa': (21 commits) [v0.14.0.x] Update release notes with change log (dashpay#3213) [v0.14.0.x] Bump version to 0.14.0.4 and draft release notes (dashpay#3203) Circumvent BIP69 sorting in fundrawtransaction.py test (dashpay#3100) Fix compile issues Merge bitcoin#11397: net: Improve and document SOCKS code Slightly optimize ApproximateBestSubset and its usage for PS txes (dashpay#3184) Update activemn if protx info changed (dashpay#3176) Actually update spent index on DisconnectBlock (dashpay#3167) Only track last seen time instead of first and last seen time (dashpay#3165) Merge bitcoin#17118: build: depends macOS: point --sysroot to SDK (dashpay#3161) Simulate BlockConnected/BlockDisconnected for PS caches Few fixes related to SelectCoinsGroupedByAddresses (dashpay#3144) Various fixes for mixing queues (dashpay#3138) Also consider txindex for transactions in AlreadyHave() (dashpay#3126) Ignore recent rejects filter for locked txes (dashpay#3124) Make orphan TX map limiting dependent on total TX size instead of TX count (dashpay#3121) Update/modernize macOS plist (dashpay#3074) Fix bip69 vs change position issue (dashpay#3063) Partially revert 3061 (dashpay#3150) Fix SelectCoinsMinConf to allow instant respends (dashpay#3061) ... # Conflicts: # configure.ac # doc/man/biblepay-cli.1 # doc/man/biblepay-qt.1 # doc/man/biblepay-tx.1 # doc/man/biblepayd.1 # doc/release-notes.md # src/clientversion.h # src/wallet/wallet.cpp
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 25, 2021
* Update activemn if protx info changed * Add `==` and `!=` operators to CDeterministicMNState * Only re-init active MN if its IP changed, changes to payout, voting etc. can be done without it * Test `masternode status` updates * Don't track mnListEntry anymore and instead get the DMN on demand * Revert "Add `==` and `!=` operators to CDeterministicMNState" This reverts commit fba4687.
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 25, 2021
This reverts commit 764e1bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a bug in
masternode statuswhere the info (e.g. payout addr, vote addr) is not being updated when aProUpRegTxis mined. This is currently only updated when the MN status is not "ready", if the MN is not in the valid list or if the operator key is changed.This is an attempt to solve this by calling
Init()in activemasternode if any of the MN's several fields are changed.Another alternative would be to just call
Init()regardless every block.